[webkit-dev] changes to gtk+ port

[David Hyatt]

Oh, by the way

https://bugs.webkit.org/show_bug.cgi?id=21083

is the bug tracking the ScrollView refactoring.

dave
(hyatt at apple.com)

On Oct 1, 2008, at 3:06 AM, David Hyatt wrote:

> ScrollView is undergoing heavy refactoring right now to make it more
> cross-platform (to enable all ports to share a lot more of the code).
> The code in question just moved (today) into the chrome clients over
> on the WebKit side.
>
> WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp
>
> The method responsible for doing repaints now is:
>
> void ChromeClient::repaint(const WebCore::IntRect& windowRect, bool
> contentChanged, bool immediate)
>
> I encourage someone to double check my work to make sure I kept the
> logic the same when moving the Gtk code over.
>
> dave
> (hyatt at apple.com)
>
> On Oct 1, 2008, at 2:54 AM, Luka Napotnik wrote:
>
>> Hello.
>>
>> I have a patch that modifies the update behavior for WebKit. The code
>> was usually in WebCore/platform/gtk/ScrollViewGtk.cpp. The missing
>> code invalidated the GdkWindow and processed updates with the code
>> that was in the method ScrollView::updateContents:
>> ---------------------------------------------------------------------------------
>> if (window)
>> gdk_window_invalidate_rect(window, &rect, true);
>>
>> // Cache the dirty spot.
>> addToDirtyRegion(containingWindowRect);
>>
>> if (now && window)
>> gdk_window_process_updates(window, true);
>> ---------------------------------------------------------------------------------
>>
>> But now I'm unable to find the code. Any hint where this updating has
>> been moved to. Please help.
>>
>> Greets,
>> Luka
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev