[webkit-dev] Moving methods from Frame to various other classes

[Shariq Rizvi]

On Fri, Dec 26, 2008 at 12:34 PM, Maciej Stachowiak <mjs at apple.com> wrote:

>
> On Dec 26, 2008, at 10:34 AM, Darin Adler wrote:
>
>  On Dec 26, 2008, at 8:41 AM, Holger Freyther wrote:
>>
>>  Okay, I have moved a lot of out Frame, Gtk+ and Qt are compiling, next
>>> thing is reviewing what I did, regression testing on Mac and then I will
>>> create one bug report and attach the patches?
>>>
>>
>> Sounds fine. The smaller and more non-controversial you can make each
>> individual patch, the better. Using a single bug report is OK, but might get
>> a bit confusing over time.
>>
>
> Yeah, bug reports that live for a long time and have many separate patches
> attached can get confusing for people who look at the review and commit
> queues. Better to use one bug report per patch or per small set of related
> patches if at all possible.
>


Perhaps make use of the "depends on" field of bug reports - which lets you
express a dependency from one bug report to another.
You can make a placeholder bug for the overall move, and then make it
"depend on" each of your N bug reports that correspond to your small
patches.




>
>  - Maciej
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20081226/c59fe28f/attachment.html>