[webkit-dev] Moving methods from Frame to various other classes

Maciej Stachowiak mjs at apple.com
Fri Dec 26 12:34:49 PST 2008


On Dec 26, 2008, at 10:34 AM, Darin Adler wrote:

> On Dec 26, 2008, at 8:41 AM, Holger Freyther wrote:
>
>> Okay, I have moved a lot of out Frame, Gtk+ and Qt are compiling,  
>> next thing is reviewing what I did, regression testing on Mac and  
>> then I will create one bug report and attach the patches?
>
> Sounds fine. The smaller and more non-controversial you can make  
> each individual patch, the better. Using a single bug report is OK,  
> but might get a bit confusing over time.

Yeah, bug reports that live for a long time and have many separate  
patches attached can get confusing for people who look at the review  
and commit queues. Better to use one bug report per patch or per small  
set of related patches if at all possible.

  - Maciej


More information about the webkit-dev mailing list