[webkit-dev] Merging wx port into TOT

Kevin Ollivier kevino at theolliviers.com
Mon Oct 8 10:55:08 PDT 2007

Hi all,

Now that the final patch to WebKit that I need for wx on TOT (MSVC7  
support) has been reviewed and approved (http://bugs.webkit.org/ 
show_bug.cgi?id=14206), all the changes left are wx-port specific, so  
I thought it was time to ask about how exactly I should merge the  
port into TOT, so that I can start work on it as soon as that patch  
has been committed.

Though it's not ideal, I'm thinking of just submitting the wx port  
for review as two patches. One for changes to existing files, and one  
adding all the new port-specific files to the tree, since the former  
is the only one that would affect other ports. I'd put them under the  
same bug number, of course, just keeping them separate to make the  
review process easier. I'm assuming the new wx port files will  
basically get a style review? Also, I should note that the code in  
WebKit/wx uses wx coding guidelines (since it's all wx classes/code,  
it seems more natural to me), so if that's a problem it might be best  
for me to know that up front. ;-)

Does this approach sound okay? Does anyone else have other ideas of  
how to approach this?



More information about the webkit-dev mailing list