[webkit-dev] recent KJS_CHECK_EXCEPTION change (needs improvement?)

Mark Rowe opendarwin.org at bdash.net.nz
Thu Jun 9 06:38:55 PDT 2005


On 10/06/2005, at 01:25 , Darin Adler wrote:

> I was looking at the recent change to KJS_CHECK_EXCEPTION, and I  
> was wondering if it's correct.
>
> It looks to me like each level is going to overwrite the source  
> file and line number set by the level below it. So the code needs  
> to change to attach a new source file and line number only if it's  
> not already set on the exception being propagated.
>
> What do you think?

Very true.  I'll send a patch through for review shortly.

Regards,

--
Mark Rowe
<http://bdash.net.nz/>




More information about the webkit-dev mailing list