[webkit-changes] [WebKit/WebKit] a4ab9b: Fix RenderListBox painting in sideways-lr writing ...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a4ab9b733b94489523b146cfb3376ed1853223c0
      https://github.com/WebKit/WebKit/commit/a4ab9b733b94489523b146cfb3376ed1853223c0
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2025-01-08 (Wed, 08 Jan 2025)

  Changed paths:
    M Source/WebCore/rendering/RenderFileUploadControl.cpp
    M Source/WebCore/rendering/RenderListBox.cpp

  Log Message:
  -----------
  Fix RenderListBox painting in sideways-lr writing mode
https://bugs.webkit.org/show_bug.cgi?id=285567
rdar://142517794

Reviewed by Aditya Keerthi.

Perform rotations / translations as needed in sideways-lr writing mode.

Reference testing is hard here unfortunately, given the scrollbar (which always shows) side changes with the writing mode.

* Source/WebCore/rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintControl): Drive-by clean-up.
* Source/WebCore/rendering/RenderListBox.cpp:
(WebCore::itemOffsetForAlignment):
(WebCore::RenderListBox::paintItemForeground):

Canonical link: https://commits.webkit.org/288601@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications