[webkit-changes] [WebKit/WebKit] 335fd4: SVGScriptElement.className.baseVal erroneously cov...

[Luke Warlow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 335fd43a016d8e26fa13dc6fba4e8207d73fea26
      https://github.com/WebKit/WebKit/commit/335fd43a016d8e26fa13dc6fba4e8207d73fea26
  Author: Luke Warlow <lwarlow at igalia.com>
  Date:   2025-01-08 (Wed, 08 Jan 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-svg-script-set-href-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-svg-script-set-href.html
    M Source/WebCore/svg/SVGURIReference.cpp
    M Source/WebCore/svg/properties/SVGAnimatedString.cpp
    M Source/WebCore/svg/properties/SVGAnimatedString.h

  Log Message:
  -----------
  SVGScriptElement.className.baseVal erroneously covered by trusted types
https://bugs.webkit.org/show_bug.cgi?id=285510

Reviewed by Tim Nguyen.

This patch changes SVGAnimatedString to only go down the Trusted Types codepath
when the property being changed is href rather than any property for an SVGScriptElement.

* LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-svg-script-set-href-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-svg-script-set-href.html:
* Source/WebCore/svg/SVGURIReference.cpp:
(WebCore::SVGURIReference::SVGURIReference):
* Source/WebCore/svg/properties/SVGAnimatedString.cpp:
(WebCore::SVGAnimatedString::setBaseVal):
* Source/WebCore/svg/properties/SVGAnimatedString.h:
(WebCore::SVGAnimatedString::create):
(WebCore::SVGAnimatedString::SVGAnimatedString):

Canonical link: https://commits.webkit.org/288602@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications