[webkit-changes] [WebKit/WebKit] 38ed09: Add more runtime checks around IPC endpoints assoc...

[Ada Chan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 38ed098deae6a1a434fb82f44dfa34793f938c55
      https://github.com/WebKit/WebKit/commit/38ed098deae6a1a434fb82f44dfa34793f938c55
  Author: Ada Chan <adachan at apple.com>
  Date:   2024-09-30 (Mon, 30 Sep 2024)

  Changed paths:
    M Source/WTF/wtf/PlatformEnableCocoa.h
    M Source/WebKit/ModelProcess/ModelConnectionToWebProcess.messages.in
    M Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.messages.in
    M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.messages.in
    M Source/WebKit/UIProcess/Model/ModelProcessProxy.cpp
    M Source/WebKit/UIProcess/WebProcessPool.cpp
    M Source/WebKit/UIProcess/WebProcessPool.h
    M Source/WebKit/UIProcess/WebProcessProxy.cpp
    M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp
    M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h
    M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.messages.in

  Log Message:
  -----------
  Add more runtime checks around IPC endpoints associated with the model process
https://bugs.webkit.org/show_bug.cgi?id=280502
rdar://123263852

Reviewed by Ryosuke Niwa and Sihui Liu.

- Update the EnabledBy checks for endpoints in the model process to include
checking the model process runtime feature flag
- Add some MESSAGE_CHECKs in ModelProcessProxy
- Assert that the model element and model process features are enabled when
WebProcessPool::ensureProtectedModelProcess() is called
- Add EnabledIf checks in ModelProcessModelPlayer to make sure the model element
and model process features are enabled

* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WebKit/ModelProcess/ModelConnectionToWebProcess.messages.in:
* Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.messages.in:
* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.messages.in:
* Source/WebKit/UIProcess/Model/ModelProcessProxy.cpp:
(WebKit::ModelProcessProxy::terminateWebProcess):
(WebKit::ModelProcessProxy::didCreateContextForVisibilityPropagation):
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureProtectedModelProcess):
(WebKit::WebProcessPool::createModelProcessConnection):
* Source/WebKit/UIProcess/WebProcessPool.h:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createModelProcessConnection):
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp:
(WebKit::ModelProcessModelPlayer::modelProcessEnabled const):
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h:
* Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.messages.in:

Canonical link: https://commits.webkit.org/284455@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications