[webkit-changes] [WebKit/WebKit] a249a9: REGRESSION(284324 at main): ASSERTION FAILED: bool(*t...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a249a901e1f65d863bd1cc085812979141f46e10
      https://github.com/WebKit/WebKit/commit/a249a901e1f65d863bd1cc085812979141f46e10
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2024-09-29 (Sun, 29 Sep 2024)

  Changed paths:
    M LayoutTests/platform/win/TestExpectations
    M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp

  Log Message:
  -----------
  REGRESSION(284324 at main): ASSERTION FAILED: bool(*this) in Markable::operator*() under WebKit::ServiceWorkerFetchTask::cancelFromClient
https://bugs.webkit.org/show_bug.cgi?id=280563

Reviewed by Chris Dumez.

In ServiceWorkerFetchTask::cancelFromClient, if
m_isLoadingFromPreloader is false, m_serviceWorkerIdentifier is empty.
We shouldn't do *m_serviceWorkerIdentifier.
Call cancelPreloadIfNecessary if m_isLoadingFromPreloader.

* LayoutTests/platform/win/TestExpectations:
* Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:
(WebKit::ServiceWorkerFetchTask::cancelFromClient):

Canonical link: https://commits.webkit.org/284441@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications