[webkit-changes] [WebKit/WebKit] a828da: [Modern Media Controls] remove window event listen...

[Xabier Rodríguez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a828da7eb601a0b75a4009529e3c439a6db7311f
      https://github.com/WebKit/WebKit/commit/a828da7eb601a0b75a4009529e3c439a6db7311f
  Author: Xabier Rodriguez-Calvar <calvaris at igalia.com>
  Date:   2024-09-29 (Sun, 29 Sep 2024)

  Changed paths:
    M Source/WebCore/Modules/modern-media-controls/controls/media-controls.js
    M Source/WebCore/Modules/modern-media-controls/media/media-controller.js

  Log Message:
  -----------
  [Modern Media Controls] remove window event listeners at deinitialization
https://bugs.webkit.org/show_bug.cgi?id=280503

Reviewed by Ryan Reno.

DOMWindow keeps media controls object alive because of installed event listeners (see
JSDOMWindow::visitAdditionalChildren). This results in extra memory usage undil DOMWindow cleared (on top level
navigation).

Original patch by Eugene Mutavchi <Ievgen_Mutavchi at comcast.com>.

* Source/WebCore/Modules/modern-media-controls/controls/media-controls.js:
(MediaControls.prototype.reenable):
* Source/WebCore/Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype.deinitialize):
(MediaController.prototype.reinitialize):

Canonical link: https://commits.webkit.org/284440@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications