[webkit-changes] [WebKit/WebKit] 476bcc: Cherry-pick 283969 at main (8ff9aac9dafb). https://bu...

[Fujii Hironori]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 476bcc74930f5fea91b04587eb90f21d5f6d4366
      https://github.com/WebKit/WebKit/commit/476bcc74930f5fea91b04587eb90f21d5f6d4366
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp

  Log Message:
  -----------
  Cherry-pick 283969 at main (8ff9aac9dafb). https://bugs.webkit.org/show_bug.cgi?id=280005

    Fix assertion in WebSWClientConnection::matchRegistration after network process crash
    https://bugs.webkit.org/show_bug.cgi?id=280005
    rdar://136310625

    Reviewed by Youenn Fablet.

    This fixes an assertion I saw on a bot with this stack trace:

    ASSERTION FAILED: Completion handler should always be called
    !m_function
    .../WebKitBuild/Debug/usr/local/include/wtf/CompletionHandler.h(66) : WTF::CompletionHandler<void (std::optional<WebCore::ServiceWorkerRegistrationData> &&)>::~CompletionHandler()
    1   WTF::CompletionHandler<void (std::__1::optional<WebCore::ServiceWorkerRegistrationData>&&)>::~CompletionHandler()
    2   WTF::CompletionHandler<void (std::__1::optional<WebCore::ServiceWorkerRegistrationData>&&)>::~CompletionHandler()
    3   WebKit::WebSWClientConnection::matchRegistration(WebCore::SecurityOriginData&&, WTF::URL const&, WTF::CompletionHandler<void (std::__1::optional<WebCore::ServiceWorkerRegistrationData>&&)>&&)::$_10::~$_10()
    4   WebKit::WebSWClientConnection::matchRegistration(WebCore::SecurityOriginData&&, WTF::URL const&, WTF::CompletionHandler<void (std::__1::optional<WebCore::ServiceWorkerRegistrationData>&&)>&&)::$_10::~$_10()
    5   WTF::Detail::CallableWrapper<WebKit::WebSWClientConnection::matchRegistration(WebCore::SecurityOriginData&&, WTF::URL const&, WTF::CompletionHandler<void (std::__1::optional<WebCore::ServiceWorkerRegistrationData>&&)>&&)::$_10, void>::~CallableWrapper()
    6   WTF::Detail::CallableWrapper<WebKit::WebSWClientConnection::matchRegistration(WebCore::SecurityOriginData&&, WTF::URL const&, WTF::CompletionHandler<void (std::__1::optional<WebCore::ServiceWorkerRegistrationData>&&)>&&)::$_10, void>::~CallableWrapper()
    7   WTF::Detail::CallableWrapper<WebKit::WebSWClientConnection::matchRegistration(WebCore::SecurityOriginData&&, WTF::URL const&, WTF::CompletionHandler<void (std::__1::optional<WebCore::ServiceWorkerRegistrationData>&&)>&&)::$_10, void>::~CallableWrapper()
    8   std::__1::default_delete<WTF::Detail::CallableWrapperBase<void>>::operator()[abi:sn170006](WTF::Detail::CallableWrapperBase<void>*) const
    9   std::__1::unique_ptr<WTF::Detail::CallableWrapperBase<void>, std::__1::default_delete<WTF::Detail::CallableWrapperBase<void>>>::reset[abi:sn170006](WTF::Detail::CallableWrapperBase<void>*)
    10  std::__1::unique_ptr<WTF::Detail::CallableWrapperBase<void>, std::__1::default_delete<WTF::Detail::CallableWrapperBase<void>>>::~unique_ptr[abi:sn170006]()
    11  std::__1::unique_ptr<WTF::Detail::CallableWrapperBase<void>, std::__1::default_delete<WTF::Detail::CallableWrapperBase<void>>>::~unique_ptr[abi:sn170006]()
    12  WTF::Function<void ()>::~Function()
    13  WTF::Function<void ()>::~Function()
    14  WTF::VectorDestructor<true, WTF::Function<void ()>>::destruct(WTF::Function<void ()>*, WTF::Function<void ()>*)
    15  WTF::VectorTypeOperations<WTF::Function<void ()>>::destruct(WTF::Function<void ()>*, WTF::Function<void ()>*)
    16  WTF::Deque<WTF::Function<void ()>, 0ul>::destroyAll()
    17  WTF::Deque<WTF::Function<void ()>, 0ul>::~Deque()
    18  WTF::Deque<WTF::Function<void ()>, 0ul>::~Deque()
    19  WebKit::WebSWClientConnection::~WebSWClientConnection()
    20  WebKit::WebSWClientConnection::~WebSWClientConnection()
    21  WebKit::WebSWClientConnection::~WebSWClientConnection()
    22  WTF::RefCounted<WebCore::SWClientConnection>::deref() const
    23  WTF::DefaultRefDerefTraits<WebKit::WebSWClientConnection>::derefIfNotNull(WebKit::WebSWClientConnection*)
    24  WTF::RefPtr<WebKit::WebSWClientConnection, WTF::RawPtrTraits<WebKit::WebSWClientConnection>, WTF::DefaultRefDerefTraits<WebKit::WebSWClientConnection>>::~RefPtr()
    25  WTF::RefPtr<WebKit::WebSWClientConnection, WTF::RawPtrTraits<WebKit::WebSWClientConnection>, WTF::DefaultRefDerefTraits<WebKit::WebSWClientConnection>>::~RefPtr()
    26  WebKit::NetworkProcessConnection::didClose(IPC::Connection&)
    27  IPC::Connection::dispatchDidCloseAndInvalidate()::$_14::operator()() const
    28  WTF::Detail::CallableWrapper<IPC::Connection::dispatchDidCloseAndInvalidate()::$_14, void>::call()
    29  WTF::Function<void ()>::operator()() const
    30  WTF::RunLoop::performWork()
    31  WTF::RunLoop::performWork(void*)

    * Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp:
    (WebKit::WebSWClientConnection::matchRegistration):

    Canonical link: https://commits.webkit.org/283969@main

Canonical link: https://commits.webkit.org/274313.436@webkitglib/2.44


  Commit: 20cfad1c39ebdd0b4cbfb648f70812774e3c9802
      https://github.com/WebKit/WebKit/commit/20cfad1c39ebdd0b4cbfb648f70812774e3c9802
  Author: Nicole Rosario <nicole_rosario at apple.com>
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
    A LayoutTests/fast/html/decrement-subframes-expected.txt
    A LayoutTests/fast/html/decrement-subframes.html
    M Source/WebCore/html/HTMLFrameOwnerElement.cpp

  Log Message:
  -----------
  Cherry-pick 283780 at main (16d8e9346f0f). https://bugs.webkit.org/show_bug.cgi?id=276637

    Hitting RELEASE_ASSERT(amount <= bitfields.connectedSubframeCount) in decrement subframe
    https://bugs.webkit.org/show_bug.cgi?id=276637
    rdar://130091196

    Reviewed by Ryosuke Niwa.

    Over decrements connectedSubframeCount (tries to decrease when it's 0)
    due to calling `frame->disconnectOwnerElement()` even if it was already
    processed

    * Source/WebCore/html/HTMLFrameOwnerElement.cpp:
    (WebCore::HTMLFrameOwnerElement::disconnectContentFrame):
    * LayoutTests/fast/html/decrement-subframes-expected.txt
    * LayoutTests/fast/html/decrement-subframes.html

    Originally-landed-as: 280938.90 at safari-7619-branch (eb3508a3bd08). rdar://136110756
    Canonical link: https://commits.webkit.org/283780@main

Canonical link: https://commits.webkit.org/274313.437@webkitglib/2.44


  Commit: 77a2eec82bac450e1e7755cc7e37a168a865582d
      https://github.com/WebKit/WebKit/commit/77a2eec82bac450e1e7755cc7e37a168a865582d
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
    M Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp

  Log Message:
  -----------
  Cherry-pick 283767 at main (290b276c74a8). https://bugs.webkit.org/show_bug.cgi?id=276645

    Add check in AudioBufferSourceNode::renderFromBuffer() when pitchRate == -1 && !needsInterpolation
    https://bugs.webkit.org/show_bug.cgi?id=276645
    rdar://130939143

    Reviewed by Andy Estes.

    Add a boundary check to renderFromBuffer() to ensure we don't read off the end of the buffer.

    * Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp:
    (WebCore::AudioBufferSourceNode::renderFromBuffer):

    Originally-landed-as: 280938.8 at safari-7619-branch (252fb2fc9cfd). rdar://136112007
    Canonical link: https://commits.webkit.org/283767@main

Canonical link: https://commits.webkit.org/274313.438@webkitglib/2.44


  Commit: 23fa110cbb81fccfff84478037dd391915634bb5
      https://github.com/WebKit/WebKit/commit/23fa110cbb81fccfff84478037dd391915634bb5
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
    M Source/WebCore/workers/service/server/SWServer.cpp

  Log Message:
  -----------
  Cherry-pick 283744 at main (5434ca72afd2). https://bugs.webkit.org/show_bug.cgi?id=279806

    Fix use-after-move in SWServer::scheduleJob
    https://bugs.webkit.org/show_bug.cgi?id=279806

    Reviewed by Chris Dumez.

    `jobData` was used after move in SWServer::scheduleJob for Windows
    port.

    * Source/WebCore/workers/service/server/SWServer.cpp:
    (WebCore::SWServer::scheduleJob):

    Canonical link: https://commits.webkit.org/283744@main

Canonical link: https://commits.webkit.org/274313.439@webkitglib/2.44


Compare: https://github.com/WebKit/WebKit/compare/46f5856d5b2f...23fa110cbb81

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications