[webkit-changes] [WebKit/WebKit] 678c69: REGRESSION(284065 at main): [GStreamer][MediaStream] ...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 678c69226d9c26d3645fb7967cac3a1a0b6119f8
      https://github.com/WebKit/WebKit/commit/678c69226d9c26d3645fb7967cac3a1a0b6119f8
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp

  Log Message:
  -----------
  REGRESSION(284065 at main): [GStreamer][MediaStream] Assertion failure ASSERTION FAILED: canSafelyBeUsed()
https://bugs.webkit.org/show_bug.cgi?id=280269

Reviewed by Xabier Rodriguez-Calvar.

Using WeakPtr for keeping track of the MediaStreamTrackPrivate in the mediastreamsrc element was a
mistake because the video frame dispatching can be triggered from a different thread.
ThreadSafeWeakPtr can't be used either, and actually there's no risk of reference cycles here, so
use RefPtr.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:

Canonical link: https://commits.webkit.org/284211@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications