[webkit-changes] [WebKit/WebKit] 878cb9: [site-isolation] Send deviceScaleFactor changes to...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 878cb9f46e7273eeb95c7262c66035ae1a0817c8
      https://github.com/WebKit/WebKit/commit/878cb9f46e7273eeb95c7262c66035ae1a0817c8
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-09-24 (Tue, 24 Sep 2024)

  Changed paths:
    A LayoutTests/http/tests/site-isolation/hidpi/device-scale-factor-paint-expected.html
    A LayoutTests/http/tests/site-isolation/hidpi/device-scale-factor-paint.html
    A LayoutTests/http/tests/site-isolation/hidpi/resources/image-set.html
    M Source/WebKit/UIProcess/API/C/WKPage.cpp
    M Source/WebKit/UIProcess/API/C/WKPage.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp
    M Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h
    M Source/WebKit/UIProcess/DrawingAreaProxy.h
    M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h
    M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h
    M Source/WebKit/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm
    M Source/WebKit/UIProcess/wc/DrawingAreaProxyWC.cpp
    M Source/WebKit/UIProcess/wc/DrawingAreaProxyWC.h
    M Source/WebKit/WebProcess/WebPage/DrawingArea.h
    M Source/WebKit/WebProcess/WebPage/DrawingArea.messages.in
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm
    M Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h
    M Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm
    M Tools/WebKitTestRunner/TestController.cpp

  Log Message:
  -----------
  [site-isolation] Send deviceScaleFactor changes to all relevant processes.
https://bugs.webkit.org/show_bug.cgi?id=280027
<rdar://136328227>

Reviewed by Kimmo Kinnunen and Alex Christensen.

Makes RemoteLayerTreeDrawingAreaProxy::deviceScaleFactorDidChange send the
change all processes that are rendering through this DrawingArea.

Adds an async callback once all the processes have acknowledged the response, so
that we can test it.

Adds a new test that changes the device scale from the main frame, and expects
the `image-set` to pick a different background image inside a remote subframe.

* LayoutTests/http/tests/site-isolation/hidpi/device-scale-factor-paint-expected.html: Added.
* LayoutTests/http/tests/site-isolation/hidpi/device-scale-factor-paint.html: Added.
* LayoutTests/http/tests/site-isolation/hidpi/resources/blue-100-px-square.png: Added.
* LayoutTests/http/tests/site-isolation/hidpi/resources/image-set.html: Added.
* Source/WebKit/UIProcess/API/C/WKPage.cpp:
(WKPageSetCustomBackingScaleFactor):
(WKPageSetCustomBackingScaleFactorWithCallback):
* Source/WebKit/UIProcess/API/C/WKPage.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setOverrideDeviceScaleFactor:]):
* Source/WebKit/UIProcess/DrawingAreaProxy.h:
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h:
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::deviceScaleFactorDidChange):
(WebKit::RemoteLayerTreeDrawingAreaProxy::forEachProcessState):
(WebKit::RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setIntrinsicDeviceScaleFactor):
(WebKit::WebPageProxy::setCustomDeviceScaleFactor):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
* Source/WebKit/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::deviceScaleFactorDidChange):
* Source/WebKit/WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setDeviceScaleFactor):
* Source/WebKit/WebProcess/WebPage/DrawingArea.messages.in:
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::setDeviceScaleFactor):
* Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setDeviceScaleFactor):
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveAsyncMessageFromInjectedBundle):

Canonical link: https://commits.webkit.org/284198@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications