[webkit-changes] [WebKit/WebKit] b7e4c4: [ iOS ] css3/filters/backdrop-filter-page-scale.ht...

mattwoodrow noreply at github.com
Tue Sep 24 20:58:36 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b7e4c4a702a5b14d31790daf0a89850516b5ddf2
      https://github.com/WebKit/WebKit/commit/b7e4c4a702a5b14d31790daf0a89850516b5ddf2
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-09-24 (Tue, 24 Sep 2024)

  Changed paths:
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
    M Source/WebKit/UIProcess/WebPageProxyTesting.cpp
    M Source/WebKit/WebProcess/WebPage/WebPageTesting.cpp
    M Source/WebKit/WebProcess/WebPage/WebPageTesting.h
    M Source/WebKit/WebProcess/WebPage/WebPageTesting.messages.in

  Log Message:
  -----------
  [ iOS ] css3/filters/backdrop-filter-page-scale.html is a flaky image failure.
https://bugs.webkit.org/show_bug.cgi?id=280260
<rdar://134269886>

Reviewed by Wenson Hsieh.

The main change here is extending the fix in 258521 at main to apply to the X axis
as well.

This test applies a page scale (with no offset) in the WebProcess (via a
WebPageProxy).  When this reaches WkWebViewIOS in the following
RemoteLayerTreeTransaction, it applies the same zoomScale, and zooms towards the
middle in the X axis. This leaves the left 200px offscreen (which includes all
the test content).  updateVisibleContentRects is then sent back to the
WebProcess with the new scroll offset, which calls setPageScaleFactor a second
time, with the scroll offset.

This test regressed by making it more async, which gives time for this multiple
transaction scrolling to take place, and then the test content is sometimes
offscreen.

This also fixes the TestRunner setPageScaleFactor setter to wait until a
rendering update has been done with the new page scale, before allowing tests to
complete.

* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _updateScrollViewForTransaction:]):
* Source/WebKit/UIProcess/WebPageProxyTesting.cpp:
(WebKit::WebPageProxyTesting::setPageScaleFactor):
* Source/WebKit/WebProcess/WebPage/WebPageTesting.cpp:
(WebKit::WebPageTesting::setPageScaleFactor):
* Source/WebKit/WebProcess/WebPage/WebPageTesting.h:
* Source/WebKit/WebProcess/WebPage/WebPageTesting.messages.in:

Canonical link: https://commits.webkit.org/284197@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list