[webkit-changes] [WebKit/WebKit] 8359d8: REGRESSION(268767 at main): [GStreamer] Audio mixer p...

Philippe Normand noreply at github.com
Tue Sep 24 00:35:52 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8359d8cb8e34e5f984be6e098df2c374c5b861c5
      https://github.com/WebKit/WebKit/commit/8359d8cb8e34e5f984be6e098df2c374c5b861c5
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-09-24 (Tue, 24 Sep 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/GStreamerAudioMixer.cpp

  Log Message:
  -----------
  REGRESSION(268767 at main): [GStreamer] Audio mixer pad unregistration triggers data flow error
https://bugs.webkit.org/show_bug.cgi?id=280185

Reviewed by Xabier Rodriguez-Calvar.

268767 at main added a new element in the pipeline, during pad registration, but it wasn't cleaned-up
during pad un-registration. Wrap the audio conversion elements in a bin in order to simplify
un-registration (no need to track each converter one by one).

* Source/WebCore/platform/graphics/gstreamer/GStreamerAudioMixer.cpp:
(WebCore::GStreamerAudioMixer::registerProducer):
(WebCore::GStreamerAudioMixer::unregisterProducer):

Canonical link: https://commits.webkit.org/284144@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list