[webkit-changes] [WebKit/WebKit] a3074b: [CMake] ENABLE_LAYOUT_TESTS should depend on DEVEL...

[Adrian Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a3074bfed0e7604980a2deebeb47b845c541cca8
      https://github.com/WebKit/WebKit/commit/a3074bfed0e7604980a2deebeb47b845c541cca8
  Author: Adrian Perez de Castro <aperez at igalia.com>
  Date:   2024-09-24 (Tue, 24 Sep 2024)

  Changed paths:
    M Source/cmake/WebKitFeatures.cmake

  Log Message:
  -----------
  [CMake] ENABLE_LAYOUT_TESTS should depend on DEVELOPER_MODE
https://bugs.webkit.org/show_bug.cgi?id=280125

Reviewed by Michael Catanzaro.

Disable ENABLE_LAYOUT_TESTS automatically if DEVELOPER_MODE is disabled.
Unfortunately DEVELOPER_MODE is not a regular option, and therefore it
is not possible to use WEBKIT_OPTION_DEPEND(); instead a manual check is
used instead.

* Source/cmake/WebKitFeatures.cmake: Check whether DEVELOPER_MODE mode
  is enabled at the end of the WEBKIT_OPTION_END() macro, and disable
  ENABLE_LAYOUT_TESTS if needed with a message using the same formatting
  as the ones produced by WEBKIT_OPTION_DEPEND(), for consistency.

Canonical link: https://commits.webkit.org/284143@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications