[webkit-changes] [WebKit/WebKit] 42049e: Make LengthSize and LengthPoint consistent

[Nathan Solomon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 42049e8173df70e36fdcffcf2369f8de82b5b7c1
      https://github.com/WebKit/WebKit/commit/42049e8173df70e36fdcffcf2369f8de82b5b7c1
  Author: Nathan Solomon <nathan_solomon at apple.com>
  Date:   2024-09-20 (Fri, 20 Sep 2024)

  Changed paths:
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    M Source/WebCore/css/BasicShapeConversion.cpp
    M Source/WebCore/css/BasicShapesShapeSegmentConversion.cpp
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/platform/LengthFunctions.cpp
    M Source/WebCore/platform/LengthPoint.cpp
    M Source/WebCore/platform/LengthPoint.h
    M Source/WebCore/platform/animation/AcceleratedEffectValues.cpp
    M Source/WebCore/rendering/MotionPath.cpp
    M Source/WebCore/rendering/RenderReplaced.cpp
    M Source/WebCore/rendering/style/ShadowData.cpp
    M Source/WebCore/rendering/style/ShadowData.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  -----------
  Make LengthSize and LengthPoint consistent
https://bugs.webkit.org/show_bug.cgi?id=277521
rdar://133228272

Reviewed by Tim Nguyen.

This fix  gets rid of using public/private control in LengthPoint, which was already a struct. It makes all members of LengthPoint public and removes their getter and setter members.

* Source/WebCore/animation/CSSPropertyAnimation.cpp:
* Source/WebCore/css/BasicShapeConversion.cpp:
(WebCore::valueForBasicShape):
* Source/WebCore/css/BasicShapesShapeSegmentConversion.cpp:
(WebCore::lengthPointToCSSValue):
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::valueForPosition):
(WebCore::isAuto):
(WebCore::isNormal):
(WebCore::valueForPathOperation):
* Source/WebCore/platform/LengthFunctions.cpp:
(WebCore::pointForLengthPoint):
(WebCore::floatPointForLengthPoint):
* Source/WebCore/platform/LengthPoint.cpp:
(WebCore::operator<<):
* Source/WebCore/platform/LengthPoint.h:
(WebCore::LengthPoint::LengthPoint):
(WebCore::LengthPoint::isZero const):
(WebCore::blend):
(WebCore::LengthPoint::setX): Deleted.
(WebCore::LengthPoint::x const): Deleted.
(WebCore::LengthPoint::setY): Deleted.
(WebCore::LengthPoint::y const): Deleted.
* Source/WebCore/platform/animation/AcceleratedEffectValues.cpp:
(WebCore::nonCalculatedLengthPoint):
(WebCore::AcceleratedEffectValues::AcceleratedEffectValues):
* Source/WebCore/rendering/MotionPath.cpp:
(WebCore::MotionPath::motionPathDataForRenderer):
(WebCore::MotionPath::applyMotionPathTransform):
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
* Source/WebCore/rendering/style/ShadowData.cpp:
(WebCore::ShadowData::ShadowData):
* Source/WebCore/rendering/style/ShadowData.h:
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::x const):
(WebCore::ShadowData::y const):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/284009@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications