[webkit-changes] [WebKit/WebKit] a6b0a2: [IsDeprecatedWeakRefSmartPointerException] Make HT...

Basuke Suzuki noreply at github.com
Fri Sep 20 13:39:10 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a6b0a2d42b02a548c67c94065f64799faa394cf3
      https://github.com/WebKit/WebKit/commit/a6b0a2d42b02a548c67c94065f64799faa394cf3
  Author: Basuke Suzuki <basuke at apple.com>
  Date:   2024-09-20 (Fri, 20 Sep 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp
    M Source/WebKit/UIProcess/API/APIHTTPCookieStore.h
    M Source/WebKit/UIProcess/API/Cocoa/WKHTTPCookieStore.mm
    M Source/WebKit/UIProcess/API/glib/WebKitCookieManager.cpp
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm
    M Source/WebKit/UIProcess/Extensions/WebExtensionController.h

  Log Message:
  -----------
  [IsDeprecatedWeakRefSmartPointerException] Make HTTPCookieStoreObserver RefCounted
https://bugs.webkit.org/show_bug.cgi?id=280072

Reviewed by Geoffrey Garen.

Every CanMakeWeakPtr class should also RefCounted.

* Source/WebKit/UIProcess/API/APIHTTPCookieStore.h:
* Source/WebKit/UIProcess/API/APIHTTPCookieStore.mm:
(HTTPCookieStore::cookiesDidChange)
* Source/WebKit/UIProcess/API/Cocoa/WKHTTPCookieStore.mm:
(WKHTTPCookieStoreObserver::create):
(-[WKHTTPCookieStore dealloc]):
(-[WKHTTPCookieStore addObserver:]):
* Source/WebKit/UIProcess/API/glib/WebKitCookieManager.cpp:
(CookieStoreObserver::create):
(webkitCookieManagerCreate):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm:
(WebKit::WebExtensionController::addWebsiteDataStore):
* Source/WebKit/UIProcess/Extensions/WebExtensionController.h:
(WebKit::WebExtensionController::HTTPCookieStoreObserver::create):

Canonical link: https://commits.webkit.org/284008@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list