[webkit-changes] [WebKit/WebKit] 93be92: REGRESSION (283478 at main): [ Sonoma arm64 wk2 Relea...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 93be927de1ed6471954cb09a1f8d5669b2f8ee41
      https://github.com/WebKit/WebKit/commit/93be927de1ed6471954cb09a1f8d5669b2f8ee41
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-09-16 (Mon, 16 Sep 2024)

  Changed paths:
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebGPU/WebGPU/XRSubImage.h
    M Source/WebGPU/WebGPU/XRSubImage.mm

  Log Message:
  -----------
  REGRESSION (283478 at main): [ Sonoma arm64 wk2 Release ] 4x http/tests/webgpu/webgpu/* tests are flaky failing
https://bugs.webkit.org/show_bug.cgi?id=279769
rdar://136087702

Reviewed by Cameron McCormack.

283478 at main introduced a retain cycle between Device and XRSubImage.

Break the retain cycle similarly to what we do for Queue: use a WeakPtr
in the non-Device class.

* Source/WebGPU/WebGPU/XRSubImage.h:
* Source/WebGPU/WebGPU/XRSubImage.mm:
(WebGPU::XRSubImage::XRSubImage):
(WebGPU::XRSubImage::update):
Break retain cycle

* LayoutTests/platform/mac-wk2/TestExpectations
Undo skipped expectations.

Canonical link: https://commits.webkit.org/283746@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications