[webkit-changes] [WebKit/WebKit] 17bdcc: [WASM] Fix and fuse br_on_null/non_null in BBQ

[David Degazio]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 17bdcc9f84777a296dcf818791307da483ada500
      https://github.com/WebKit/WebKit/commit/17bdcc9f84777a296dcf818791307da483ada500
  Author: David Degazio <d_degazio at apple.com>
  Date:   2024-09-16 (Mon, 16 Sep 2024)

  Changed paths:
    M Source/JavaScriptCore/wasm/WasmBBQJIT32_64.cpp
    M Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp

  Log Message:
  -----------
  [WASM] Fix and fuse br_on_null/non_null in BBQ
https://bugs.webkit.org/show_bug.cgi?id=279701
rdar://135586113

Reviewed by Yusuke Suzuki.

Changes the BBQ implementations of br_on_null and br_on_non_null to
avoid calling addBranch() with an intermediate value. This resolves
some debug-only assertion failures with these instructions, and
also serves to fuse the compare and branch to make these instructions
a bit more efficient.

* Source/JavaScriptCore/wasm/WasmBBQJIT32_64.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::addBranchNull):
* Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::addBranchNull):

Canonical link: https://commits.webkit.org/283745@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications