[webkit-changes] [WebKit/WebKit] 9717bf: [text-underline-position] Paint invalidation somet...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9717bfc4323e2572882082795474702eaf568470
      https://github.com/WebKit/WebKit/commit/9717bfc4323e2572882082795474702eaf568470
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-09-13 (Fri, 13 Sep 2024)

  Changed paths:
    A LayoutTests/fast/repaint/vertical-rl-repaint-when-decoration-changes-expected.txt
    A LayoutTests/fast/repaint/vertical-rl-repaint-when-decoration-changes.html
    M Source/WebCore/rendering/RenderElement.cpp

  Log Message:
  -----------
  [text-underline-position] Paint invalidation sometimes does not properly work
https://bugs.webkit.org/show_bug.cgi?id=279611
<rdar://problem/135904727>

Reviewed by Simon Fraser.

Repaint _after_ layout logic is broken with flipped writing mode in block direction. See webkit.org/b/70762 for details.

This is stop-gap solution to cover incorrect repaints triggered by style changes until
after we figure out the best way to compute repaint rects for such flipped content.
This aligns with what we already do for content type changes.

(Note that this does not cover cases where content grows and/or moves)

* LayoutTests/fast/repaint/vertical-rl-repaint-when-decoration-changes-expected.txt: Added.
* LayoutTests/fast/repaint/vertical-rl-repaint-when-decoration-changes.html: Added.
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::repaintBeforeStyleChange):

Canonical link: https://commits.webkit.org/283666@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications