[webkit-changes] [WebKit/WebKit] ace3c0: Use the correct bounding rect in SVGInlineTextBox:...

Ahmad Saleem noreply at github.com
Fri Sep 13 19:38:08 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ace3c089eef49f9501a928fe5803c97723ac163e
      https://github.com/WebKit/WebKit/commit/ace3c089eef49f9501a928fe5803c97723ac163e
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-09-13 (Fri, 13 Sep 2024)

  Changed paths:
    A LayoutTests/svg/hittest/text-vertical-expected.txt
    A LayoutTests/svg/hittest/text-vertical.html
    M Source/WebCore/rendering/svg/SVGInlineTextBox.cpp

  Log Message:
  -----------
  Use the correct bounding rect in SVGInlineTextBox::nodeAtPoint

https://bugs.webkit.org/show_bug.cgi?id=279692
rdar://135973175

Reviewed by Simon Fraser.

Merge: https://source.chromium.org/chromium/chromium/src/+/ccf72ce87493b653f3f1add48b2bd0a68108d35b

This patch leverages 'loigcalWidth' and 'logicalHeight' instead of 'size'
for hittesting to get correct bounding rect in cases of vertical writing modes.

* Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::nodeAtPoint):
* LayoutTests/svg/hittest/text-vertical.html:
* LayoutTests/svg/hittest/text-vertical-expected.txt:

Canonical link: https://commits.webkit.org/283665@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list