[webkit-changes] [WebKit/WebKit] 81dfda: Use an enum class for CSSValue Type

Nathan Solomon noreply at github.com
Thu Sep 12 09:58:22 PDT 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81dfdabf3b60c3d6ec78ad6c52c901731223d4da
      https://github.com/WebKit/WebKit/commit/81dfdabf3b60c3d6ec78ad6c52c901731223d4da
  Author: Nathan Solomon <nathan_solomon at apple.com>
  Date:   2024-09-12 (Thu, 12 Sep 2024)

  Changed paths:
    M Source/WebCore/css/CSSAnchorValue.h
    M Source/WebCore/css/CSSAspectRatioValue.h
    M Source/WebCore/css/CSSBackgroundRepeatValue.cpp
    M Source/WebCore/css/CSSBasicShapes.cpp
    M Source/WebCore/css/CSSBorderImageSliceValue.cpp
    M Source/WebCore/css/CSSBorderImageWidthValue.cpp
    M Source/WebCore/css/CSSCanvasValue.cpp
    M Source/WebCore/css/CSSContentDistributionValue.cpp
    M Source/WebCore/css/CSSCounterValue.cpp
    M Source/WebCore/css/CSSCrossfadeValue.cpp
    M Source/WebCore/css/CSSCursorImageValue.cpp
    M Source/WebCore/css/CSSCustomPropertyValue.h
    M Source/WebCore/css/CSSFilterImageValue.cpp
    M Source/WebCore/css/CSSFontFaceSrcValue.cpp
    M Source/WebCore/css/CSSFontFeatureValue.cpp
    M Source/WebCore/css/CSSFontPaletteValuesOverrideColorsValue.h
    M Source/WebCore/css/CSSFontStyleRangeValue.h
    M Source/WebCore/css/CSSFontStyleWithAngleValue.cpp
    M Source/WebCore/css/CSSFontValue.h
    M Source/WebCore/css/CSSFontVariantAlternatesValue.cpp
    M Source/WebCore/css/CSSFontVariationValue.cpp
    M Source/WebCore/css/CSSFunctionValue.cpp
    M Source/WebCore/css/CSSGradientValue.h
    M Source/WebCore/css/CSSGridAutoRepeatValue.cpp
    M Source/WebCore/css/CSSGridIntegerRepeatValue.cpp
    M Source/WebCore/css/CSSGridLineNamesValue.cpp
    M Source/WebCore/css/CSSGridLineValue.cpp
    M Source/WebCore/css/CSSGridTemplateAreasValue.cpp
    M Source/WebCore/css/CSSImageSetOptionValue.cpp
    M Source/WebCore/css/CSSImageSetValue.cpp
    M Source/WebCore/css/CSSImageValue.cpp
    M Source/WebCore/css/CSSLineBoxContainValue.cpp
    M Source/WebCore/css/CSSNamedImageValue.cpp
    M Source/WebCore/css/CSSOffsetRotateValue.h
    M Source/WebCore/css/CSSPaintImageValue.cpp
    M Source/WebCore/css/CSSPendingSubstitutionValue.h
    M Source/WebCore/css/CSSPrimitiveValue.cpp
    M Source/WebCore/css/CSSQuadValue.cpp
    M Source/WebCore/css/CSSRayValue.h
    M Source/WebCore/css/CSSRectValue.cpp
    M Source/WebCore/css/CSSReflectValue.cpp
    M Source/WebCore/css/CSSScrollValue.h
    M Source/WebCore/css/CSSShadowValue.cpp
    M Source/WebCore/css/CSSShapeSegmentValue.h
    M Source/WebCore/css/CSSSubgridValue.cpp
    M Source/WebCore/css/CSSTimingFunctionValue.h
    M Source/WebCore/css/CSSTransformListValue.cpp
    M Source/WebCore/css/CSSUnicodeRangeValue.h
    M Source/WebCore/css/CSSValue.cpp
    M Source/WebCore/css/CSSValue.h
    M Source/WebCore/css/CSSValueList.cpp
    M Source/WebCore/css/CSSValuePair.cpp
    M Source/WebCore/css/CSSVariableReferenceValue.cpp
    M Source/WebCore/css/CSSViewValue.h
    M Source/WebCore/css/calc/CSSCalcValue.cpp

  Log Message:
  -----------
  Use an enum class for CSSValue Type
https://bugs.webkit.org/show_bug.cgi?id=277660
rdar://133256102

Reviewed by Tim Nguyen.

Convert the enum ClassType into an enum class.

* Source/WebCore/css/CSSAnchorValue.h:
* Source/WebCore/css/CSSAspectRatioValue.h:
* Source/WebCore/css/CSSBackgroundRepeatValue.cpp:
(WebCore::CSSBackgroundRepeatValue::CSSBackgroundRepeatValue):
* Source/WebCore/css/CSSBasicShapes.cpp:
(WebCore::CSSCircleValue::CSSCircleValue):
(WebCore::CSSEllipseValue::CSSEllipseValue):
(WebCore::CSSXywhValue::CSSXywhValue):
(WebCore::CSSRectShapeValue::CSSRectShapeValue):
(WebCore::CSSPathValue::CSSPathValue):
(WebCore::CSSPolygonValue::CSSPolygonValue):
(WebCore::CSSInsetShapeValue::CSSInsetShapeValue):
(WebCore::CSSShapeValue::CSSShapeValue):
* Source/WebCore/css/CSSBorderImageSliceValue.cpp:
(WebCore::CSSBorderImageSliceValue::CSSBorderImageSliceValue):
* Source/WebCore/css/CSSBorderImageWidthValue.cpp:
(WebCore::CSSBorderImageWidthValue::CSSBorderImageWidthValue):
* Source/WebCore/css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::CSSCanvasValue):
* Source/WebCore/css/CSSContentDistributionValue.cpp:
(WebCore::CSSContentDistributionValue::CSSContentDistributionValue):
* Source/WebCore/css/CSSCounterValue.cpp:
(WebCore::CSSCounterValue::CSSCounterValue):
* Source/WebCore/css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
* Source/WebCore/css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::CSSCursorImageValue):
* Source/WebCore/css/CSSCustomPropertyValue.h:
* Source/WebCore/css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::CSSFilterImageValue):
* Source/WebCore/css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcLocalValue::CSSFontFaceSrcLocalValue):
(WebCore::CSSFontFaceSrcResourceValue::CSSFontFaceSrcResourceValue):
* Source/WebCore/css/CSSFontFeatureValue.cpp:
(WebCore::CSSFontFeatureValue::CSSFontFeatureValue):
* Source/WebCore/css/CSSFontPaletteValuesOverrideColorsValue.h:
* Source/WebCore/css/CSSFontStyleRangeValue.h:
* Source/WebCore/css/CSSFontStyleWithAngleValue.cpp:
(WebCore::CSSFontStyleWithAngleValue::CSSFontStyleWithAngleValue):
* Source/WebCore/css/CSSFontValue.h:
* Source/WebCore/css/CSSFontVariantAlternatesValue.cpp:
(WebCore::CSSFontVariantAlternatesValue::CSSFontVariantAlternatesValue):
* Source/WebCore/css/CSSFontVariationValue.cpp:
(WebCore::CSSFontVariationValue::CSSFontVariationValue):
* Source/WebCore/css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::CSSFunctionValue):
* Source/WebCore/css/CSSGradientValue.h:
* Source/WebCore/css/CSSGridAutoRepeatValue.cpp:
(WebCore::CSSGridAutoRepeatValue::CSSGridAutoRepeatValue):
* Source/WebCore/css/CSSGridIntegerRepeatValue.cpp:
(WebCore::CSSGridIntegerRepeatValue::CSSGridIntegerRepeatValue):
* Source/WebCore/css/CSSGridLineNamesValue.cpp:
(WebCore::CSSGridLineNamesValue::CSSGridLineNamesValue):
* Source/WebCore/css/CSSGridTemplateAreasValue.cpp:
(WebCore::CSSGridTemplateAreasValue::CSSGridTemplateAreasValue):
* Source/WebCore/css/CSSImageSetOptionValue.cpp:
(WebCore::CSSImageSetOptionValue::CSSImageSetOptionValue):
* Source/WebCore/css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::CSSImageSetValue):
* Source/WebCore/css/CSSImageValue.cpp:
(WebCore::CSSImageValue::CSSImageValue):
* Source/WebCore/css/CSSLineBoxContainValue.cpp:
(WebCore::CSSLineBoxContainValue::CSSLineBoxContainValue):
* Source/WebCore/css/CSSNamedImageValue.cpp:
(WebCore::CSSNamedImageValue::CSSNamedImageValue):
* Source/WebCore/css/CSSOffsetRotateValue.h:
* Source/WebCore/css/CSSPaintImageValue.cpp:
(WebCore::CSSPaintImageValue::CSSPaintImageValue):
* Source/WebCore/css/CSSPendingSubstitutionValue.h:
* Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* Source/WebCore/css/CSSQuadValue.cpp:
(WebCore::CSSQuadValue::CSSQuadValue):
* Source/WebCore/css/CSSRayValue.h:
* Source/WebCore/css/CSSRectValue.cpp:
(WebCore::CSSRectValue::CSSRectValue):
* Source/WebCore/css/CSSReflectValue.cpp:
(WebCore::CSSReflectValue::CSSReflectValue):
* Source/WebCore/css/CSSScrollValue.h:
* Source/WebCore/css/CSSShadowValue.cpp:
(WebCore::CSSShadowValue::CSSShadowValue):
* Source/WebCore/css/CSSShapeSegmentValue.h:
(WebCore::CSSShapeSegmentValue::CSSShapeSegmentValue):
* Source/WebCore/css/CSSSubgridValue.cpp:
(WebCore::CSSSubgridValue::CSSSubgridValue):
* Source/WebCore/css/CSSTimingFunctionValue.h:
* Source/WebCore/css/CSSTransformListValue.cpp:
(WebCore::CSSTransformListValue::CSSTransformListValue):
* Source/WebCore/css/CSSUnicodeRangeValue.h:
* Source/WebCore/css/CSSValue.cpp:
(WebCore::CSSValue::visitDerived):
(WebCore::CSSValue::createDeprecatedCSSOMWrapper const):
* Source/WebCore/css/CSSValue.h:
(WebCore::CSSValue::isAnchorValue const):
(WebCore::CSSValue::isAspectRatioValue const):
(WebCore::CSSValue::isBackgroundRepeatValue const):
(WebCore::CSSValue::isBorderImageSliceValue const):
(WebCore::CSSValue::isBorderImageWidthValue const):
(WebCore::CSSValue::isCalcValue const):
(WebCore::CSSValue::isCanvasValue const):
(WebCore::CSSValue::isCircle const):
(WebCore::CSSValue::isConicGradientValue const):
(WebCore::CSSValue::isContentDistributionValue const):
(WebCore::CSSValue::isCounter const):
(WebCore::CSSValue::isCrossfadeValue const):
(WebCore::CSSValue::isCubicBezierTimingFunctionValue const):
(WebCore::CSSValue::isCursorImageValue const):
(WebCore::CSSValue::isCustomPropertyValue const):
(WebCore::CSSValue::isDeprecatedLinearGradientValue const):
(WebCore::CSSValue::isDeprecatedRadialGradientValue const):
(WebCore::CSSValue::isEllipse const):
(WebCore::CSSValue::isFilterImageValue const):
(WebCore::CSSValue::isFontFaceSrcLocalValue const):
(WebCore::CSSValue::isFontFaceSrcResourceValue const):
(WebCore::CSSValue::isFontFeatureValue const):
(WebCore::CSSValue::isFontPaletteValuesOverrideColorsValue const):
(WebCore::CSSValue::isFontStyleRangeValue const):
(WebCore::CSSValue::isFontStyleWithAngleValue const):
(WebCore::CSSValue::isFontValue const):
(WebCore::CSSValue::isFontVariantAlternatesValue const):
(WebCore::CSSValue::isFontVariationValue const):
(WebCore::CSSValue::isFunctionValue const):
(WebCore::CSSValue::isGridAutoRepeatValue const):
(WebCore::CSSValue::isGridIntegerRepeatValue const):
(WebCore::CSSValue::isGridLineNamesValue const):
(WebCore::CSSValue::isGridTemplateAreasValue const):
(WebCore::CSSValue::isImageSetOptionValue const):
(WebCore::CSSValue::isImageSetValue const):
(WebCore::CSSValue::isImageValue const):
(WebCore::CSSValue::isInsetShape const):
(WebCore::CSSValue::isLineBoxContainValue const):
(WebCore::CSSValue::isLinearGradientValue const):
(WebCore::CSSValue::isLinearTimingFunctionValue const):
(WebCore::CSSValue::isNamedImageValue const):
(WebCore::CSSValue::isOffsetRotateValue const):
(WebCore::CSSValue::isPair const):
(WebCore::CSSValue::isPath const):
(WebCore::CSSValue::isPendingSubstitutionValue const):
(WebCore::CSSValue::isPolygon const):
(WebCore::CSSValue::isPrefixedLinearGradientValue const):
(WebCore::CSSValue::isPrefixedRadialGradientValue const):
(WebCore::CSSValue::isPrimitiveValue const):
(WebCore::CSSValue::isQuad const):
(WebCore::CSSValue::isRadialGradientValue const):
(WebCore::CSSValue::isRayValue const):
(WebCore::CSSValue::isRect const):
(WebCore::CSSValue::isRectShape const):
(WebCore::CSSValue::isReflectValue const):
(WebCore::CSSValue::isScrollValue const):
(WebCore::CSSValue::isShadowValue const):
(WebCore::CSSValue::isShape const):
(WebCore::CSSValue::isShapeSegment const):
(WebCore::CSSValue::isSpringTimingFunctionValue const):
(WebCore::CSSValue::isStepsTimingFunctionValue const):
(WebCore::CSSValue::isSubgridValue const):
(WebCore::CSSValue::isTransformListValue const):
(WebCore::CSSValue::isUnicodeRangeValue const):
(WebCore::CSSValue::isValueList const):
(WebCore::CSSValue::isVariableReferenceValue const):
(WebCore::CSSValue::isViewValue const):
(WebCore::CSSValue::isXywhShape const):
(WebCore::CSSValue::isPaintImageValue const):
(WebCore::CSSValue::isGradientValue const):
(WebCore::CSSValue::isImageGeneratorValue const):
(WebCore::CSSValue::containsVector const):
* Source/WebCore/css/CSSValueList.cpp:
(WebCore::CSSValueList::CSSValueList):
* Source/WebCore/css/CSSValuePair.cpp:
(WebCore::CSSValuePair::CSSValuePair):
* Source/WebCore/css/CSSVariableReferenceValue.cpp:
(WebCore::CSSVariableReferenceValue::CSSVariableReferenceValue):
* Source/WebCore/css/CSSViewValue.h:
* Source/WebCore/css/calc/CSSCalcValue.cpp:
(WebCore::CSSCalcValue::CSSCalcValue):

Canonical link: https://commits.webkit.org/283564@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list