[webkit-changes] [WebKit/WebKit] b2b8d3: [GTK][WPE][Skia] Invalid result or crash when pain...

[Pawel Lampe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b2b8d3a40c38799195f6374ced4e0f4b28dcac17
      https://github.com/WebKit/WebKit/commit/b2b8d3a40c38799195f6374ced4e0f4b28dcac17
  Author: Pawel Lampe <plampe at igalia.com>
  Date:   2024-09-12 (Thu, 12 Sep 2024)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/html/ImageBitmap.cpp
    M Source/WebCore/html/ImageBitmap.h
    M Source/WebCore/platform/graphics/ImageBuffer.cpp
    M Source/WebCore/platform/graphics/ImageBuffer.h
    M Source/WebCore/workers/DedicatedWorkerGlobalScope.cpp
    M Source/WebCore/workers/Worker.cpp

  Log Message:
  -----------
  [GTK][WPE][Skia] Invalid result or crash when painting an accelerated ImageBitmap into WebGL
https://bugs.webkit.org/show_bug.cgi?id=278908

Reviewed by Carlos Garcia Campos.

When using skia, transferring ownership of accelerated ImageBitmaps causes GrDirectContext mismatches
that lead to problems with reading pixels, drawing etc. Therefore, we need to let ImageBitmap know
the transfer is happening so that it can act accordingly and e.g. decelerate underlying ImageBuffer.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/html/ImageBitmap.cpp:
(WebCore::ImageBitmap::createImageBuffer):
(WebCore::ImageBitmap::prepareForCrossThreadTransfer):
* Source/WebCore/html/ImageBitmap.h:
* Source/WebCore/platform/graphics/ImageBuffer.cpp:
(WebCore::copyImageBuffer):
(WebCore::ImageBuffer::sinkIntoImageBufferForCrossThreadTransfer):
* Source/WebCore/platform/graphics/ImageBuffer.h:
* Source/WebCore/workers/DedicatedWorkerGlobalScope.cpp:
(WebCore::DedicatedWorkerGlobalScope::postMessage):
* Source/WebCore/workers/Worker.cpp:
(WebCore::Worker::postMessage):

Canonical link: https://commits.webkit.org/283563@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications