[webkit-changes] [WebKit/WebKit] f38a9d: NEW TEST (283218 at main): [ macOS ] 2x TestWebKitAPI...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f38a9ddefa06b1729cf108a818ca74b1eaa791be
      https://github.com/WebKit/WebKit/commit/f38a9ddefa06b1729cf108a818ca74b1eaa791be
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-09-10 (Tue, 10 Sep 2024)

  Changed paths:
    M Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.h
    M Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.serialization.in
    M Source/WebKit/webpushd/PushClientConnection.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm

  Log Message:
  -----------
  NEW TEST (283218 at main): [ macOS ] 2x TestWebKitAPI.WebPushD test are constant failures.
https://bugs.webkit.org/show_bug.cgi?id=279279
rdar://135435896

Reviewed by Brady Eidson.

The tests fail as entitlement check does not work with public SDK, and PushClientConnection::create() falls to check
hostAppAuditTokenData in configuration. hostAppAuditTokenData is not set when PushClientConnection is created for
API::WebPushDaemonConnection, so validating the size of hostAppAuditTokenData would fail and PushClientConnection is not
created. To fix this, make hostAppAuditTokenData optional in WebPushDaemonConnectionConfiguration and skip validating
it when it is null. To ensure correctness, PushClientConnection::create() now uses audit token from peer connection
when hostAppAuditTokenData is not provided.

* Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.h:
* Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.serialization.in:
* Source/WebKit/webpushd/PushClientConnection.mm:
(WebPushD::PushClientConnection::create):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:

Canonical link: https://commits.webkit.org/283426@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications