[webkit-changes] [WebKit/WebKit] 56de25: File input types does not show open panel in Web E...

Timothy Hatcher noreply at github.com
Tue Sep 10 10:49:51 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 56de25583c7603d9b3260a7fc75db10f9dfbe58d
      https://github.com/WebKit/WebKit/commit/56de25583c7603d9b3260a7fc75db10f9dfbe58d
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-09-10 (Tue, 10 Sep 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm

  Log Message:
  -----------
  File input types does not show open panel in Web Extension on Mac.
https://webkit.org/b/279417
rdar://135651344

Reviewed by Jeff Miller.

Address review feedback I missed originally before merging 283418 at main.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(-[_WKWebExtensionContextDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
(WebKit::WebExtensionContext::runOpenPanel): Call completion handler on early return.

Canonical link: https://commits.webkit.org/283425@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list