[webkit-changes] [WebKit/WebKit] 015ec6: Content on oldreddit is after the sidebar, not alo...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 015ec6709c126c1299405fd39a9c53fb2065c2b1
      https://github.com/WebKit/WebKit/commit/015ec6709c126c1299405fd39a9c53fb2065c2b1
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-09-07 (Sat, 07 Sep 2024)

  Changed paths:
    A LayoutTests/fast/block/float/float-avoider-with-negative-margin-expected.html
    A LayoutTests/fast/block/float/float-avoider-with-negative-margin.html
    M Source/WebCore/rendering/RenderBox.cpp

  Log Message:
  -----------
  Content on oldreddit is after the sidebar, not alongside
https://bugs.webkit.org/show_bug.cgi?id=279297
<rdar://134742752>

Reviewed by Antti Koivisto.

Negative horizontal margin is not supposed to make border box wider.

1. Float avoider with 'auto' width calls shrinkLogicalWidthToAvoidFloats to figure out
how much space there is at a certain vertical position (to grow)
2. We use this available space to size the float avoider's border box in return

* LayoutTests/fast/block/float/float-avoider-with-negative-margin-expected.html: Added.
* LayoutTests/fast/block/float/float-avoider-with-negative-margin.html: Added.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats const):

Canonical link: https://commits.webkit.org/283298@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications