[webkit-changes] [WebKit/WebKit] 0d2b96: [visionOS] Have dedicated button to enter spatial ...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0d2b962e0ef808a86cf9b5336eda203e08141df6
      https://github.com/WebKit/WebKit/commit/0d2b962e0ef808a86cf9b5336eda203e08141df6
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-09-07 (Sat, 07 Sep 2024)

  Changed paths:
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm

  Log Message:
  -----------
  [visionOS] Have dedicated button to enter spatial portal from element fullscreen
https://bugs.webkit.org/show_bug.cgi?id=279171
rdar://135306130

Reviewed by Jer Noble.

If the video's contain spatial metadata, display a dedicated button to go into video fullscreen
instead of using the environment picker button.
Pressing on the button will enter spatial portal mode.
The icon is for now just a generic "video" one.

Manually tested.

* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h:
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController videoControlsManagerDidChange]):
(-[WKFullScreenViewController configureEnvironmentPickerOrFullscreenVideoButtonView]):
(-[WKFullScreenViewController _removeEnvironmentPickerButtonView]):
(-[WKFullScreenViewController _removeEnvironmentFullscreenVideoButtonView]):
(-[WKFullScreenViewController loadView]):
(-[WKFullScreenViewController _enterVideoFullscreenAction:]):
(-[WKFullScreenViewController configureEnvironmentPickerButtonView]): Deleted.
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController didCleanupFullscreen]):

Canonical link: https://commits.webkit.org/283297@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications