[webkit-changes] [WebKit/WebKit] 79915f: model portal should allow rectangular aspect ratio

Ada Chan noreply at github.com
Wed Sep 4 22:52:56 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 79915f4ac88b69ed7d0c317ae49e271ca738f68e
      https://github.com/WebKit/WebKit/commit/79915f4ac88b69ed7d0c317ae49e271ca738f68e
  Author: Ada Chan <adachan at apple.com>
  Date:   2024-09-04 (Wed, 04 Sep 2024)

  Changed paths:
    M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm

  Log Message:
  -----------
  model portal should allow rectangular aspect ratio
https://bugs.webkit.org/show_bug.cgi?id=279158
rdar://99045742

Reviewed by Mike Wyrzykowski.

Use the proper height for the model portal layer.
Update the initial entity transform computation to use the bounding
box center for the translation.

* Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm:
(WebKit::computeScaledExtentsAndCenter):
(WebKit::computeSRT):
(WebKit::ModelProcessModelPlayerProxy::computeTransform):
(WebKit::ModelProcessModelPlayerProxy::didFinishLoading):
(WebKit::ModelProcessModelPlayerProxy::layer):
(WebKit::computeExtents): Deleted.

Canonical link: https://commits.webkit.org/283193@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list