[webkit-changes] [WebKit/WebKit] 76b7aa: [WebGPU] Device lost and uncaptured errors callbac...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 76b7aa864431b1838ae32b4913e7efcd07415827
      https://github.com/WebKit/WebKit/commit/76b7aa864431b1838ae32b4913e7efcd07415827
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-09-04 (Wed, 04 Sep 2024)

  Changed paths:
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp
    M Source/WebGPU/WebGPU/Device.mm
    M Source/WebGPU/WebGPU/WebGPUExt.h

  Log Message:
  -----------
  [WebGPU] Device lost and uncaptured errors callbacks were being retained too long
https://bugs.webkit.org/show_bug.cgi?id=279131
rdar://135283160

Reviewed by Dan Glastonbury.

When the remote IPC interface goes away, we need to call the callback
to ensure the async IPC message which was setup gets called at some point.

Otherwise, we retain the completion handler every time the page is refreshed, leading
to an effective memory leak.

* Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp:
(WebCore::WebGPU::DeviceImpl::~DeviceImpl):
* Source/WebGPU/WebGPU/Device.mm:
(WebGPU::Device::~Device):
(WebGPU::Device::setUncapturedErrorCallback):
* Source/WebGPU/WebGPU/WebGPUExt.h:

Canonical link: https://commits.webkit.org/283192@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications