[webkit-changes] [WebKit/WebKit] 99b543: [appearance: base] Parse CSS value behind preference

Tim Nguyen noreply at github.com
Tue Sep 3 12:50:55 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 99b543382e3319efc6fd8de52d20b96d19c81d9a
      https://github.com/WebKit/WebKit/commit/99b543382e3319efc6fd8de52d20b96d19c81d9a
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/css/CSSPrimitiveValueMappings.h
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/CSSValueKeywords.in
    M Source/WebCore/css/parser/CSSParserContext.cpp
    M Source/WebCore/css/parser/CSSParserContext.h
    M Source/WebCore/platform/StyleAppearance.cpp
    M Source/WebCore/platform/StyleAppearance.h
    M Source/WebCore/rendering/RenderTheme.cpp
    M Source/WebCore/rendering/style/RenderStyleInlines.h

  Log Message:
  -----------
  [appearance: base] Parse CSS value behind preference
https://bugs.webkit.org/show_bug.cgi?id=279069
rdar://135203123

Reviewed by Aditya Keerthi.

Add basic parsing for `appearance: base` behind a preference, so we can prototype upon it.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::toCSSValueID):
(WebCore::fromCSSValueID):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::add):
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/platform/StyleAppearance.cpp:
(WebCore::operator<<):
* Source/WebCore/platform/StyleAppearance.h:
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::createControlPart const):
(WebCore::RenderTheme::paintBorderOnly):
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::hasAppearance const):
(WebCore::RenderStyle::hasUsedAppearance const):

Canonical link: https://commits.webkit.org/283106@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list