[webkit-changes] [WebKit/WebKit] 1ec3f8: Don't show fullscreen phishing alert when Fullscre...

aestes noreply at github.com
Tue Sep 3 11:38:59 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1ec3f8ced15e3f486f363de9772f3571f942ffe1
      https://github.com/WebKit/WebKit/commit/1ec3f8ced15e3f486f363de9772f3571f942ffe1
  Author: Andy Estes <aestes at apple.com>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm

  Log Message:
  -----------
  Don't show fullscreen phishing alert when Fullscreen API is disabled
https://bugs.webkit.org/show_bug.cgi?id=279035
rdar://129370027

Reviewed by Jer Noble.

In clients where the Fullscreen API is disabled it is not possible to present arbitrary web content
in fullscreen. However, if the VideoFullscreenRequiresElementFullscreen preference is enabled then
it is possible to present a <video> element in fullscreen with built-in WebKit media controls. In
this configuration it is not valuable to present a phishing alert, so this change disables it.

* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController _showPhishingAlert]):

Canonical link: https://commits.webkit.org/283105@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list