[webkit-changes] [WebKit/WebKit] 61abd2: Cherry-pick 282753 at main (b2f4995bd769). https://bu...

ziransun noreply at github.com
Tue Sep 3 05:05:13 PDT 2024 

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 61abd22e31a3151c66b73a2b0a2cf30af7efb6f5
      https://github.com/WebKit/WebKit/commit/61abd22e31a3151c66b73a2b0a2cf30af7efb6f5
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    M Source/WebCore/Modules/fetch/FetchBodySource.cpp
    M Source/WebCore/Modules/fetch/FetchBodySource.h
    M Source/WebCore/Modules/fetch/FetchResponse.cpp
    M Source/WebCore/Modules/fetch/FetchResponse.h
    M Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp
    M Source/WebCore/Modules/plugins/YouTubePluginReplacement.h
    M Source/WebCore/Modules/speech/SpeechRecognitionEvent.cpp
    M Source/WebCore/Modules/speech/SpeechRecognitionEvent.h
    M Source/WebCore/Modules/storage/StorageConnection.h
    M Source/WebCore/Modules/webaudio/AudioBasicProcessorNode.cpp
    M Source/WebCore/Modules/webaudio/AudioBasicProcessorNode.h
    M Source/WebCore/animation/CSSTransition.cpp
    M Source/WebCore/animation/CSSTransition.h
    M Source/WebCore/animation/DocumentTimeline.cpp
    M Source/WebCore/animation/DocumentTimeline.h
    M Source/WebCore/crypto/keys/CryptoKeyEC.cpp
    M Source/WebCore/crypto/keys/CryptoKeyEC.h
    M Source/WebCore/css/typedom/CSSUnparsedValue.cpp
    M Source/WebCore/css/typedom/CSSUnparsedValue.h
    M Source/WebCore/css/typedom/transform/CSSPerspective.cpp
    M Source/WebCore/css/typedom/transform/CSSPerspective.h
    M Source/WebCore/css/typedom/transform/CSSTransformValue.cpp
    M Source/WebCore/css/typedom/transform/CSSTransformValue.h
    M Source/WebCore/dom/DragEvent.cpp
    M Source/WebCore/dom/DragEvent.h
    M Source/WebCore/dom/InputEvent.cpp
    M Source/WebCore/dom/InputEvent.h
    M Source/WebCore/editing/ReplaceSelectionCommand.cpp
    M Source/WebCore/editing/ReplaceSelectionCommand.h
    M Source/WebCore/html/CollectionTraversalInlines.h
    M Source/WebCore/html/GenericCachedHTMLCollection.cpp
    M Source/WebCore/html/GenericCachedHTMLCollection.h
    M Source/WebCore/html/PluginDocument.cpp
    M Source/WebCore/html/PluginDocument.h
    M Source/WebCore/loader/cache/CachedSVGFont.cpp
    M Source/WebCore/loader/cache/CachedSVGFont.h
    M Source/WebCore/page/WorkerNavigator.cpp
    M Source/WebCore/page/WorkerNavigator.h
    M Source/WebCore/platform/audio/AudioDSPKernelProcessor.cpp
    M Source/WebCore/platform/audio/AudioDSPKernelProcessor.h
    M Source/WebCore/platform/audio/cocoa/WebAudioBufferList.cpp
    M Source/WebCore/platform/audio/cocoa/WebAudioBufferList.h
    M Source/WebCore/platform/gamepad/cocoa/GameControllerGamepadProvider.h
    M Source/WebCore/platform/gamepad/cocoa/GameControllerGamepadProvider.mm
    M Source/WebCore/platform/graphics/NativeImage.cpp
    M Source/WebCore/platform/graphics/NativeImage.h
    M Source/WebCore/platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h
    M Source/WebCore/platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm
    M Source/WebCore/platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.cpp
    M Source/WebCore/platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.h
    M Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h
    M Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm
    M Source/WebCore/platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.h
    M Source/WebCore/platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.mm
    M Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp
    M Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.h
    M Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.h
    M Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm
    M Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp
    M Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.h
    M Source/WebCore/platform/mock/MockRealtimeVideoSource.h
    M Source/WebCore/rendering/style/BasicShapes.cpp
    M Source/WebCore/rendering/style/BasicShapes.h
    M Source/WebKit/NetworkProcess/Downloads/PendingDownload.cpp
    M Source/WebKit/NetworkProcess/Downloads/PendingDownload.h
    M Source/WebKit/Shared/WebImage.cpp
    M Source/WebKit/Shared/WebImage.h
    M Source/WebKit/UIProcess/API/APIInspectorConfiguration.cpp
    M Source/WebKit/UIProcess/API/APIInspectorConfiguration.h
    M Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.cpp
    M Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.h
    M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
    M Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp
    M Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxyInternals.h
    M Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp
    M Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h
    M Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h
    M Source/WebKit/WebProcess/Inspector/WebPageInspectorTarget.cpp
    M Source/WebKit/WebProcess/Inspector/WebPageInspectorTarget.h
    M Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp
    M Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.h
    M Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp
    M Source/WebKit/WebProcess/WebPage/WebCookieCache.h
    M Source/WebKit/WebProcess/WebStorage/StorageNamespaceImpl.cpp
    M Source/WebKit/WebProcess/WebStorage/StorageNamespaceImpl.h
    M Source/WebKitLegacy/ios/WebCoreSupport/WebInspectorClientIOS.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm

  Log Message:
  -----------
  Cherry-pick 282753 at main (b2f4995bd769). https://bugs.webkit.org/show_bug.cgi?id=278576

    Move WebCore/WebKitLegacy/WebKit destructors to source files for upstream clang
    <https://bugs.webkit.org/show_bug.cgi?id=278630>
    <rdar://134660411>

    Reviewed by Darin Adler.

    In upstream clang, destructors require full class definitions for any
    instance variable that is destructed.  In most cases, moving the
    destructor out of the header fixes this build failure without
    increasing header parsing time.  Alternate fixes are noted below.

    * Source/WebCore/Modules/fetch/FetchBodySource.cpp:
    * Source/WebCore/Modules/fetch/FetchBodySource.h:
    * Source/WebCore/Modules/fetch/FetchResponse.cpp:
    * Source/WebCore/Modules/fetch/FetchResponse.h:
    * Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:
    * Source/WebCore/Modules/plugins/YouTubePluginReplacement.h:
    * Source/WebCore/Modules/speech/SpeechRecognitionEvent.cpp:
    * Source/WebCore/Modules/speech/SpeechRecognitionEvent.h:
    * Source/WebCore/Modules/storage/StorageConnection.h:
    - Replace struct StorageEstimate predeclaration by including
      StorageEstimate.h since it's a small struct.
    * Source/WebCore/Modules/webaudio/AudioBasicProcessorNode.cpp:
    * Source/WebCore/Modules/webaudio/AudioBasicProcessorNode.h:
    * Source/WebCore/animation/CSSTransition.cpp:
    * Source/WebCore/animation/CSSTransition.h:
    * Source/WebCore/animation/DocumentTimeline.cpp:
    * Source/WebCore/animation/DocumentTimeline.h:
    * Source/WebCore/crypto/keys/CryptoKeyEC.cpp:
    * Source/WebCore/crypto/keys/CryptoKeyEC.h:
    * Source/WebCore/css/typedom/CSSUnparsedValue.cpp:
    * Source/WebCore/css/typedom/CSSUnparsedValue.h:
    * Source/WebCore/css/typedom/transform/CSSPerspective.cpp:
    * Source/WebCore/css/typedom/transform/CSSPerspective.h:
    * Source/WebCore/css/typedom/transform/CSSTransformValue.cpp:
    * Source/WebCore/css/typedom/transform/CSSTransformValue.h:
    * Source/WebCore/dom/DragEvent.cpp:
    * Source/WebCore/dom/DragEvent.h:
    * Source/WebCore/dom/InputEvent.cpp:
    * Source/WebCore/dom/InputEvent.h:
    * Source/WebCore/editing/ReplaceSelectionCommand.cpp:
    * Source/WebCore/editing/ReplaceSelectionCommand.h:
    * Source/WebCore/html/CollectionTraversalInlines.h:
    - Include HTMLOptionsCollectionInlines.h since this is needed in some
      source files.
    * Source/WebCore/html/GenericCachedHTMLCollection.cpp:
    * Source/WebCore/html/GenericCachedHTMLCollection.h:
    * Source/WebCore/html/PluginDocument.cpp:
    * Source/WebCore/html/PluginDocument.h:
    * Source/WebCore/loader/cache/CachedSVGFont.cpp:
    * Source/WebCore/loader/cache/CachedSVGFont.h:
    * Source/WebCore/page/WorkerNavigator.cpp:
    * Source/WebCore/page/WorkerNavigator.h:
    * Source/WebCore/platform/audio/AudioDSPKernelProcessor.cpp:
    * Source/WebCore/platform/audio/AudioDSPKernelProcessor.h:
    * Source/WebCore/platform/audio/cocoa/WebAudioBufferList.cpp:
    * Source/WebCore/platform/audio/cocoa/WebAudioBufferList.h:
    * Source/WebCore/platform/gamepad/cocoa/GameControllerGamepadProvider.h:
    * Source/WebCore/platform/gamepad/cocoa/GameControllerGamepadProvider.mm:
    * Source/WebCore/platform/graphics/BitmapImageSource.cpp:
    * Source/WebCore/platform/graphics/BitmapImageSource.h:
    * Source/WebCore/platform/graphics/NativeImage.cpp:
    * Source/WebCore/platform/graphics/NativeImage.h:
    * Source/WebCore/platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h:
    * Source/WebCore/platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
    * Source/WebCore/platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.cpp:
    * Source/WebCore/platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.h:
    * Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
    * Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
    * Source/WebCore/platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.h:
    * Source/WebCore/platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.mm:
    * Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:
    * Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.h:
    * Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.h:
    * Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:
    * Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:
    * Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.h:
    * Source/WebCore/platform/mock/MockRealtimeVideoSource.h:
    * Source/WebCore/rendering/style/BasicShapes.cpp:
    * Source/WebCore/rendering/style/BasicShapes.h:
    * Source/WebKit/NetworkProcess/Downloads/PendingDownload.cpp:
    * Source/WebKit/NetworkProcess/Downloads/PendingDownload.h:
    * Source/WebKit/Shared/WebImage.cpp:
    * Source/WebKit/Shared/WebImage.h:
    - Also mark WebImage class as final.
    * Source/WebKit/UIProcess/API/APIInspectorConfiguration.cpp:
    * Source/WebKit/UIProcess/API/APIInspectorConfiguration.h:
    * Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
    * Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.h:
    * Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
    - Include headers require for WebPageProxy::Internals destructor.
    - Declare WebPageProxy::Internals destructor for Cocoa platforms.
    * Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp:
    * Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.h:
    * Source/WebKit/UIProcess/WebPageProxy.cpp:
    - Move class definition of WebPageProxyFrameLoadStateObserver to
      WebPageProxyInternals.h, leaving constructor and destructor here.
    - Declare WebPageProxy::Internals destructor for non-Cocoa platforms.
    * Source/WebKit/UIProcess/WebPageProxyInternals.h:
    - Move class definition of WebPageProxyFrameLoadStateObserver to here
      from WebPageProxy.cpp.
    * Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:
    * Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h:
    * Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:
    * Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:
    * Source/WebKit/WebProcess/Inspector/WebPageInspectorTarget.cpp:
    * Source/WebKit/WebProcess/Inspector/WebPageInspectorTarget.h:
    * Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
    * Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.h:
    * Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp:
    * Source/WebKit/WebProcess/WebPage/WebCookieCache.h:
    - Also mark WebCookieCache class as final.
    * Source/WebKit/WebProcess/WebStorage/StorageNamespaceImpl.cpp:
    * Source/WebKit/WebProcess/WebStorage/StorageNamespaceImpl.h:
    * Source/WebKitLegacy/ios/WebCoreSupport/WebInspectorClientIOS.mm:
    * Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h:
    * Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm:

    Canonical link: https://commits.webkit.org/282753@main

Canonical link: https://commits.webkit.org/274313.407@webkitglib/2.44


  Commit: 1de12ec39882693c3d49d7b9330a89897b4991a2
      https://github.com/WebKit/WebKit/commit/1de12ec39882693c3d49d7b9330a89897b4991a2
  Author: Ziran Sun <zsun at igalia.com>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp

  Log Message:
  -----------
  Cherry-pick 282726 at main (188b29f2ba50). https://bugs.webkit.org/show_bug.cgi?id=264708

    Remove assertion check for AppendPipeline::handleErrorConditionFromStreamingThread().
    https://bugs.webkit.org/show_bug.cgi?id=264708

    Reviewed by Alicia Boya Garcia.

    The assertion is not valid any more due to the change at [1], in which
    the MSE's Reset Parser State algorithm and the `abort()` operation are
    queued to run sequentially. And abortting and resetting the parser only
    once the previous operations have completed.

    [1] https://github.com/WebKit/WebKit/pull/12498

    * LayoutTests/platform/glib/TestExpectations:
    * Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:
    (WebCore::AppendPipeline::handleErrorConditionFromStreamingThread):

    Canonical link: https://commits.webkit.org/282726@main

Canonical link: https://commits.webkit.org/274313.408@webkitglib/2.44


Compare: https://github.com/WebKit/WebKit/compare/3637305650ee...1de12ec39882

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list