[webkit-changes] [WebKit/WebKit] ef7ef8: [WebRTC] Add support for legacy Offer options

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ef7ef86e4cf56ad91d0a06677ba8de5de8cc3f1e
      https://github.com/WebKit/WebKit/commit/ef7ef86e4cf56ad91d0a06677ba8de5de8cc3f1e
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/resources/import-expectations.json
    A LayoutTests/imported/w3c/web-platform-tests/webrtc/legacy/README.txt
    A LayoutTests/imported/w3c/web-platform-tests/webrtc/legacy/RTCPeerConnection-createOffer-offerToReceive-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/webrtc/legacy/RTCPeerConnection-createOffer-offerToReceive.html
    A LayoutTests/imported/w3c/web-platform-tests/webrtc/legacy/RTCRtpTransceiver-with-OfferToReceive-options.https-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/webrtc/legacy/RTCRtpTransceiver-with-OfferToReceive-options.https.html
    A LayoutTests/imported/w3c/web-platform-tests/webrtc/legacy/munge-dont-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/webrtc/legacy/munge-dont.html
    A LayoutTests/imported/w3c/web-platform-tests/webrtc/legacy/onaddstream.https.html
    A LayoutTests/imported/w3c/web-platform-tests/webrtc/legacy/simplecall_callbacks.https.html
    A LayoutTests/imported/w3c/web-platform-tests/webrtc/legacy/w3c-import.log
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/tests-options.json
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp
    M Source/WebCore/Modules/mediastream/PeerConnectionBackend.h
    M Source/WebCore/Modules/mediastream/RTCOfferOptions.h
    M Source/WebCore/Modules/mediastream/RTCOfferOptions.idl
    M Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
    M Source/WebCore/Modules/mediastream/RTCPeerConnection.h
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.h
    M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
    M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h
    M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp
    M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h

  Log Message:
  -----------
  [WebRTC] Add support for legacy Offer options
https://bugs.webkit.org/show_bug.cgi?id=256707
<rdar://problem/109569164>

Reviewed by Youenn Fablet.

Some websites still rely on the legacy offer options, despite the spec recommendation of using
transceivers, so bring back those options, behind a runtime WebPreference, disabled by default.

Covered by new tests backported from WPT.
Upstream commit: https://github.com/web-platform-tests/wpt/commit/9c29d4eefd4d5d41822f6fdccaf59b14f0603965

* LayoutTests/TestExpectations:
* LayoutTests/platform/glib/TestExpectations:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::addTransceiver):
* Source/WebCore/Modules/mediastream/PeerConnectionBackend.h:
* Source/WebCore/Modules/mediastream/RTCOfferOptions.h:
* Source/WebCore/Modules/mediastream/RTCOfferOptions.idl:
* Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::addReceiveOnlyTransceiver):
(WebCore::RTCPeerConnection::createOffer):
* Source/WebCore/Modules/mediastream/RTCPeerConnection.h:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::createTransceiverBackends):
(WebCore::GStreamerMediaEndpoint::addTransceiver):
(WebCore::GStreamerMediaEndpoint::onNegotiationNeeded):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp:
(WebCore::GStreamerPeerConnectionBackend::addTransceiverFromTrackOrKind):
(WebCore::GStreamerPeerConnectionBackend::addTransceiver):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.h:
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::createTransceiverBackends):
(WebCore::LibWebRTCMediaEndpoint::addTransceiver):
(WebCore::LibWebRTCMediaEndpoint::OnNegotiationNeededEvent):
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::LibWebRTCPeerConnectionBackend::addTransceiverFromTrackOrKind):
(WebCore::LibWebRTCPeerConnectionBackend::addTransceiver):
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:

Canonical link: https://commits.webkit.org/283089@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications