[webkit-changes] [WebKit/WebKit] 557909: [GTK] Crash on inputting booking field on IRCTC we...

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 55790984429f1c921d2eff6ade9331938cae0364
      https://github.com/WebKit/WebKit/commit/55790984429f1c921d2eff6ade9331938cae0364
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2024-10-30 (Wed, 30 Oct 2024)

  Changed paths:
    M Source/WebKit/UIProcess/API/glib/WebKitUserContentManager.cpp

  Log Message:
  -----------
  [GTK] Crash on inputting booking field on IRCTC website in ScriptMessageClientGtk::didPostMessage
https://bugs.webkit.org/show_bug.cgi?id=280150

Reviewed by Adrian Perez de Castro.

Epiphany is failing to unregister a script message handler, causing it
to be emitted after its corresponding WebKitWebView and
WebKitUserContentManager have been destroyed. There are basically three
ways we could handle this: (a) detect it and ignore it, (b) detect it
and emit a warning or critical, and (c) proactively prevent it by
storing a HashMap containing all message handlers and unregistering any
that still exist when the WebKitUserContentManager is destroyed.

Maybe (c) would be best, but I'm lazy, so I chose option (b).

I spent a little while trying to create an API test for this, but it
doesn't seem simple.

* Source/WebKit/UIProcess/API/glib/WebKitUserContentManager.cpp:

Canonical link: https://commits.webkit.org/285924@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications