[webkit-changes] [WebKit/WebKit] 00c21d: Cherry-pick 285901 at main (6641652afa8a). https://bu...

[Michael Catanzaro]

  Branch: refs/heads/webkitglib/2.46
  Home:   https://github.com/WebKit/WebKit
  Commit: 00c21deac3fb4b347b13ed5b3ef0e714fcfd0f63
      https://github.com/WebKit/WebKit/commit/00c21deac3fb4b347b13ed5b3ef0e714fcfd0f63
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2024-10-30 (Wed, 30 Oct 2024)

  Changed paths:
    M Source/bmalloc/CMakeLists.txt
    M Source/cmake/WebKitCompilerFlags.cmake

  Log Message:
  -----------
  Cherry-pick 285901 at main (6641652afa8a). https://bugs.webkit.org/show_bug.cgi?id=282275

    C compiler flags improperly used when compiling libpas source files as C++
    https://bugs.webkit.org/show_bug.cgi?id=282275

    Reviewed by Adrian Perez de Castro.

    Distros might encounter this warning when building several libpas source
    files:

    cc1plus: warning: ‘-Werror=’ argument ‘-Werror=implicit-function-declaration’ is not valid for C++

    It's caused because we are going behind CMake's back by telling the C
    compiler to build for C++ using -xc++. CMake thinks we're building as C,
    so it passes along CFLAGS and CMAKE_C_FLAGS as usual, which is wrong.
    Instead, let's simply tell CMake that these files are C++.

    * Source/bmalloc/CMakeLists.txt:
    * Source/cmake/WebKitCompilerFlags.cmake:

    Canonical link: https://commits.webkit.org/285901@main

Canonical link: https://commits.webkit.org/282416.264@webkitglib/2.46



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications