[webkit-changes] [WebKit/WebKit] 02f76c: Update MediaSource.cpp to comply with new CPP-safe...

Jean-Yves Avenard noreply at github.com
Wed Oct 30 06:13:45 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 02f76ccb0345a51164a5f1e7a57a774cf7e445eb
      https://github.com/WebKit/WebKit/commit/02f76ccb0345a51164a5f1e7a57a774cf7e445eb
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-10-30 (Wed, 30 Oct 2024)

  Changed paths:
    M Source/WebCore/Modules/mediasource/ManagedMediaSource.cpp
    M Source/WebCore/Modules/mediasource/MediaSource.cpp
    M Source/WebCore/Modules/mediasource/MediaSource.h
    M Source/WebCore/Modules/mediasource/SourceBufferList.cpp
    M Source/WebCore/Modules/mediasource/SourceBufferList.h
    M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations

  Log Message:
  -----------
  Update MediaSource.cpp to comply with new CPP-safer rules.
https://bugs.webkit.org/show_bug.cgi?id=282303
rdar://138878642

Reviewed by Youenn Fablet.

Make SourceBufferList use Vector<Ref<SourceBuffer>> as storage.
Adopt more smart pointers to access SourceBuffer and MediaSourcePrivate.

No observable change.

* Source/WebCore/Modules/mediasource/ManagedMediaSource.cpp:
(WebCore::ManagedMediaSource::setStreaming):
(WebCore::ManagedMediaSource::streamingTimerFired):
* Source/WebCore/Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::setPrivateAndOpen):
(WebCore::MediaSource::reOpen):
(WebCore::MediaSource::duration const):
(WebCore::MediaSource::currentTime const):
(WebCore::MediaSource::buffered const):
(WebCore::MediaSource::waitForTarget):
(WebCore::MediaSource::seekToTime):
(WebCore::MediaSource::seekable):
(WebCore::MediaSource::setLiveSeekableRange):
(WebCore::MediaSource::clearLiveSeekableRange):
(WebCore::MediaSource::hasBufferedTime):
(WebCore::MediaSource::hasFutureTime):
(WebCore::MediaSource::isBuffered const):
(WebCore::MediaSource::monitorSourceBuffers):
(WebCore::MediaSource::setDuration):
(WebCore::MediaSource::setDurationInternal):
(WebCore::MediaSource::setReadyState):
(WebCore::MediaSource::streamEndedWithError):
(WebCore::MediaSource::detachFromElement):
(WebCore::MediaSource::openIfInEndedState):
(WebCore::MediaSource::readyState const):
(WebCore::MediaSource::createSourceBufferPrivate):
(WebCore::MediaSource::regenerateActiveSourceBuffers):
(WebCore::MediaSource::updateBufferedIfNeeded):
(WebCore::MediaSource::sourceBufferReceivedFirstInitializationSegmentChanged):
(WebCore::MediaSource::sourceBufferActiveTrackFlagChanged):
(WebCore::MediaSource::setMediaPlayerReadyState):
(WebCore::MediaSource::protectedPrivate const):
* Source/WebCore/Modules/mediasource/MediaSource.h:
* Source/WebCore/Modules/mediasource/SourceBufferList.cpp:
(WebCore::SourceBufferList::contains const):
(WebCore::SourceBufferList::item const):
(WebCore::SourceBufferList::remove):
(WebCore::SourceBufferList::replaceWith):
* Source/WebCore/Modules/mediasource/SourceBufferList.h:
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:

Canonical link: https://commits.webkit.org/285899@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list