[webkit-changes] [WebKit/WebKit] d467f7: [IFC][shape-outside] Assertion and missing content...

Alan Baradlay noreply at github.com
Wed Oct 30 06:08:21 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d467f7299ccd0009d3eef07ce3b7ef7d10ea7879
      https://github.com/WebKit/WebKit/commit/d467f7299ccd0009d3eef07ce3b7ef7d10ea7879
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-10-30 (Wed, 30 Oct 2024)

  Changed paths:
    A LayoutTests/fast/inline/missing-content-with-shape-outside-float-expected.html
    A LayoutTests/fast/inline/missing-content-with-shape-outside-float.html
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp

  Log Message:
  -----------
  [IFC][shape-outside] Assertion and missing content with shape-outside
https://bugs.webkit.org/show_bug.cgi?id=282315
<rdar://138873821>

Reviewed by Antti Koivisto.

Add missing "line is constrained by float" bit when we can't place any content on the
line due to floats that we didn't see when the line was being initialized.

It happens when there are no floats at the initial vertical position but as
we try to place some inline content on the line the (vertically) inflated line is now constrained by a float.

* LayoutTests/fast/inline/missing-content-with-shape-outside-float-expected.html: Added.
* LayoutTests/fast/inline/missing-content-with-shape-outside-float.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::handleInlineContent):

Canonical link: https://commits.webkit.org/285898@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list