[webkit-changes] [WebKit/WebKit] 642ca0: Sometimes, WKTR installation does not succeed in t...

Per Arne Vollan noreply at github.com
Fri Oct 25 10:27:25 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 642ca0497fb33759aead6b05d2ed5a109e55664f
      https://github.com/WebKit/WebKit/commit/642ca0497fb33759aead6b05d2ed5a109e55664f
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
    M Tools/Scripts/webkitpy/xcode/simulated_device.py
    A Tools/WebKitTestRunner/Configurations/WebKitEligibilityUtil.xcconfig
    A Tools/WebKitTestRunner/WebKitEligibilityUtil/main.cpp
    M Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Sometimes, WKTR installation does not succeed in the Simulator
https://bugs.webkit.org/show_bug.cgi?id=281875
rdar://138351968

Reviewed by Elliott Williams.

This is caused by a daemon involved in the installation being suspended. This patch works around this
issue by creating a small utility that sends a XPC message to the daemon in order to resume execution.
This issue is flaky, so it is hard to confirm the fix is sufficient, but local testing looks good.

This patch was previously reviewed in https://github.com/WebKit/WebKit/pull/35544 and landed in
https://commits.webkit.org/285637@main. It is being relanded with a build fix for Debug mode.

* Tools/Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDevice.install_app):
* Tools/WebKitTestRunner/Configurations/WebKitEligibilityUtil.xcconfig: Added.
* Tools/WebKitTestRunner/WebKitEligibilityUtil/main.cpp: Added.
(main):
* Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/285704@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list