[webkit-changes] [WebKit/WebKit] 31e806: Remove RSAES-pkcs1-v1.5 support

Fri Oct 25 09:25:35 PDT 2024

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 31e806507852348d649add0eab1363d9a1fdab12
      https://github.com/WebKit/WebKit/commit/31e806507852348d649add0eab1363d9a1fdab12
  Author: Nitin Mahendru <nitinmahendru at apple.com>
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-jwk-expected.txt
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-jwk.html
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-pkcs8-expected.txt
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-pkcs8.html
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-spki-expected.txt
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-spki.html
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-encrypt-decrypt-expected.txt
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-encrypt-decrypt.html
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-expected.txt
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-extractable-expected.txt
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-extractable.html
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key.html
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-private-key-expected.txt
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-private-key.html
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-empty-usages-expected.txt
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-empty-usages.html
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-expected.txt
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero-expected.txt
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero.html
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-minimum-expected.txt
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-minimum.html
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-non-extractable-expected.txt
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-non-extractable.html
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key.html
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-decrypt-expected.txt
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-decrypt.html
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-encrypt-expected.txt
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-encrypt.html
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-pkcs8-key-expected.txt
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-pkcs8-key.html
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key-empty-usages-expected.txt
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key-empty-usages.html
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key-expected.txt
    R LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key.html
    R LayoutTests/crypto/workers/subtle/rsa-postMessage-worker-expected.txt
    R LayoutTests/crypto/workers/subtle/rsa-postMessage-worker.html
    R LayoutTests/crypto/workers/subtle/rsaes-pkcs1-v1_5-import-key-decrypt-expected.txt
    R LayoutTests/crypto/workers/subtle/rsaes-pkcs1-v1_5-import-key-decrypt.html
    R LayoutTests/crypto/workers/subtle/rsaes-pkcs1-v1_5-import-key-encrypt-expected.txt
    R LayoutTests/crypto/workers/subtle/rsaes-pkcs1-v1_5-import-key-encrypt.html
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/Sources.txt
    M Source/WebCore/SourcesCocoa.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/crypto/SubtleCrypto.cpp
    R Source/WebCore/crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp
    R Source/WebCore/crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h
    R Source/WebCore/crypto/cocoa/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp
    M Source/WebCore/crypto/cocoa/CryptoAlgorithmRegistryMac.cpp
    R Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp
    M Source/WebCore/crypto/gcrypt/CryptoAlgorithmRegistryGCrypt.cpp
    R Source/WebCore/crypto/openssl/CryptoAlgorithmRSAES_PKCS1_v1_5OpenSSL.cpp
    M Source/WebCore/crypto/openssl/CryptoAlgorithmRegistryOpenSSL.cpp
    M Source/WebCore/platform/OpenSSL.cmake
    M Source/WebCore/platform/SourcesGCrypt.txt

  Log Message:
  -----------
  Remove RSAES-pkcs1-v1.5 support
https://bugs.webkit.org/show_bug.cgi?id=281144
rdar://137603955

Reviewed by David Kilzer and Youenn Fablet.

It is already deprecated in chrome and firefox and we have had it disabled by default for some
time now. See: https://commits.webkit.org/259018@main

It should be safe to just remove it now as we haven't heard any claims.
It's an algorithm with a long history of issues and should not be used.
more details:
https://datatracker.ietf.org/doc/html/rfc8017#section-7.2

* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-jwk-expected.txt: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-jwk.html: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-pkcs8-expected.txt: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-pkcs8.html: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-spki-expected.txt: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-export-key-spki.html: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-encrypt-decrypt-expected.txt: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-encrypt-decrypt.html: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-expected.txt: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-extractable-expected.txt: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key-extractable.html: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-generate-key.html: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-private-key-expected.txt: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-private-key.html: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-empty-usages-expected.txt: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-empty-usages.html: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-expected.txt: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero-expected.txt: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-leading-zero.html: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-minimum-expected.txt: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-minimum.html: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-non-extractable-expected.txt: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key-non-extractable.html: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-jwk-public-key.html: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-decrypt-expected.txt: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-decrypt.html: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-encrypt-expected.txt: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-key-encrypt.html: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-pkcs8-key-expected.txt: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-pkcs8-key.html: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key-empty-usages-expected.txt: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key-empty-usages.html: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key-expected.txt: Removed.
* LayoutTests/crypto/subtle/rsaes-pkcs1-v1_5-import-spki-key.html: Removed.
* LayoutTests/crypto/workers/subtle/rsa-postMessage-worker-expected.txt: Removed.
* LayoutTests/crypto/workers/subtle/rsa-postMessage-worker.html: Removed.
* LayoutTests/crypto/workers/subtle/rsaes-pkcs1-v1_5-import-key-decrypt-expected.txt: Removed.
* LayoutTests/crypto/workers/subtle/rsaes-pkcs1-v1_5-import-key-decrypt.html: Removed.
* LayoutTests/crypto/workers/subtle/rsaes-pkcs1-v1_5-import-key-encrypt-expected.txt: Removed.
* LayoutTests/crypto/workers/subtle/rsaes-pkcs1-v1_5-import-key-encrypt.html: Removed.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Sources.txt:
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/crypto/SubtleCrypto.cpp:
(WebCore::normalizeCryptoAlgorithmParameters):
(WebCore::isSupportedExportKey):
(WebCore::isRSAESPKCSWebCryptoDeprecated): Deleted.
* Source/WebCore/crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp: Removed.
* Source/WebCore/crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h: Removed.
* Source/WebCore/crypto/cocoa/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp: Removed.
* Source/WebCore/crypto/cocoa/CryptoAlgorithmRegistryMac.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
* Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp: Removed.
* Source/WebCore/crypto/gcrypt/CryptoAlgorithmRegistryGCrypt.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
* Source/WebCore/crypto/openssl/CryptoAlgorithmRSAES_PKCS1_v1_5OpenSSL.cpp: Removed.
* Source/WebCore/crypto/openssl/CryptoAlgorithmRegistryOpenSSL.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
* Source/WebCore/platform/OpenSSL.cmake:
* Source/WebCore/platform/SourcesGCrypt.txt:

Canonical link: https://commits.webkit.org/285703@main

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications