[webkit-changes] [WebKit/WebKit] ecad60: LAYER_POSITIONS_ASSERT(*repaintRects() == renderer...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ecad604cdd3b06223d005e2fe8ad463b3b936a94
      https://github.com/WebKit/WebKit/commit/ecad604cdd3b06223d005e2fe8ad463b3b936a94
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-10-23 (Wed, 23 Oct 2024)

  Changed paths:
    A LayoutTests/fast/layers/overflow-change-crash-expected.html
    A LayoutTests/fast/layers/overflow-change-crash.html
    M Source/WebCore/rendering/RenderLayer.cpp

  Log Message:
  -----------
  LAYER_POSITIONS_ASSERT(*repaintRects() == renderer().rectsForRepaintingAfterLayout(repaintContainer.get(), RepaintOutlineBounds::Yes)); on https://gregbenzphotography.com/hdr-gain-map-gallery
https://bugs.webkit.org/show_bug.cgi?id=281946
<rdar://138451742>

Reviewed by Simon Fraser.

Changing overflow visibility affects the repaints of all descendants (that share
the same repaint container, which isn't tracked by the current dirty bits). The
existing marking (based on layout) only marked the children of the changed
layer, not all descendants.

* LayoutTests/fast/layers/overflow-change-crash-expected.html: Added.
* LayoutTests/fast/layers/overflow-change-crash.html: Added.
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects const):

Canonical link: https://commits.webkit.org/285627@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications