[webkit-changes] [WebKit/WebKit] a13b10: [Web Push] Incoming push transactions are timing out

[bnham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a13b10925ad7c4ff1828569652ee6df2ced203e7
      https://github.com/WebKit/WebKit/commit/a13b10925ad7c4ff1828569652ee6df2ced203e7
  Author: Ben Nham <nham at apple.com>
  Date:   2024-10-23 (Wed, 23 Oct 2024)

  Changed paths:
    M Source/WebKit/webpushd/WebPushDaemon.mm

  Log Message:
  -----------
  [Web Push] Incoming push transactions are timing out
https://bugs.webkit.org/show_bug.cgi?id=282001
rdar://138503883

Reviewed by Brady Eidson.

While debugging some Web Push issues, I noticed log messages claiming that the os_transaction we
hold as part of handling incoming pushes is constantly timing out after 10 seconds. The reason for
this is I accidentally removed the line that releases the transaction in 280760 at main.

Practically speaking, nothing too bad happens here other than webpushd having an elevated jetsam
level for ~10s and error log spam. But we should still fix this.

* Source/WebKit/webpushd/WebPushDaemon.mm:
(WebPushD::WebPushDaemon::getPendingPushMessages):

Canonical link: https://commits.webkit.org/285626@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications