[webkit-changes] [WebKit/WebKit] 1dc9ae: Use different keychain attribute for passkey crede...

[Jason Lee]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1dc9ae6c18649e69843343042de19d3042e64d2e
      https://github.com/WebKit/WebKit/commit/1dc9ae6c18649e69843343042de19d3042e64d2e
  Author: Jason Lee <jlee32 at apple.com>
  Date:   2024-10-22 (Tue, 22 Oct 2024)

  Changed paths:
    M Source/WTF/wtf/spi/cocoa/SecuritySPI.h
    M Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.h
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm
    M Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm

  Log Message:
  -----------
  Use different keychain attribute for passkey credential ID
https://bugs.webkit.org/show_bug.cgi?id=281344
rdar://137771569

Reviewed by Brent Fulgham.

Use kSecAttrAlias going forward, and if a query using this field fails then fall
back to kSecAttrApplicationLabel

* Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(getAllLocalAuthenticatorCredentialsImpl):
(+[_WKWebAuthenticationPanel deleteLocalAuthenticatorCredentialWithGroupAndID:credential:]):
(+[_WKWebAuthenticationPanel setDisplayNameForLocalCredentialWithGroupAndID:credential:displayName:]):
(+[_WKWebAuthenticationPanel setNameForLocalCredentialWithGroupAndID:credential:name:]):
(+[_WKWebAuthenticationPanel importLocalAuthenticatorWithAccessGroup:credential:error:]):
(+[_WKWebAuthenticationPanel exportLocalAuthenticatorCredentialWithGroupAndID:credential:error:]):
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticatorInternal::produceHashSet):
(WebKit::LocalAuthenticator::getExistingCredentials):
(WebKit::LocalAuthenticator::processLargeBlobExtension):
(WebKit::LocalAuthenticator::continueMakeCredentialAfterUserVerification):
(WebKit::LocalAuthenticator::continueGetAssertionAfterUserVerification):
(WebKit::LocalAuthenticator::receiveException const):
(WebKit::LocalAuthenticator::deleteDuplicateCredential const):
* Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::cleanUpKeychain):
(WTR::TestController::keyExistsInKeychain):

Canonical link: https://commits.webkit.org/285575@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications