[webkit-changes] [WebKit/WebKit] 726001: [WebGPU] Importing an external texture prior to su...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 72600125740237812b193f15294d5a9cf38e7b07
      https://github.com/WebKit/WebKit/commit/72600125740237812b193f15294d5a9cf38e7b07
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-10-22 (Tue, 22 Oct 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/nocrash/fuzz-281778-expected.txt
    A LayoutTests/fast/webgpu/nocrash/fuzz-281778.html
    M Source/WebCore/Modules/WebGPU/GPUBindGroup.cpp
    M Source/WebCore/Modules/WebGPU/GPUBindGroup.h
    M Source/WebCore/Modules/WebGPU/GPUDevice.cpp
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUBindGroupImpl.cpp
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUBindGroupImpl.h
    M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBindGroup.h
    M Source/WebGPU/WebGPU/BindGroup.h
    M Source/WebGPU/WebGPU/BindGroup.mm
    M Source/WebGPU/WebGPU/ExternalTexture.h
    M Source/WebGPU/WebGPU/ExternalTexture.mm
    M Source/WebGPU/WebGPU/WebGPUExt.h
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.cpp
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.h
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.messages.in
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBindGroupProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBindGroupProxy.h

  Log Message:
  -----------
  [WebGPU] Importing an external texture prior to submitting a command buffer containing the prior external texture may result in validation errors
https://bugs.webkit.org/show_bug.cgi?id=281778
rdar://137965924

Reviewed by Dan Glastonbury.

Don't allow bind group reuse when the bind group is currently in use
by a command buffer.

* LayoutTests/fast/webgpu/nocrash/fuzz-281778-expected.txt: Added.
* LayoutTests/fast/webgpu/nocrash/fuzz-281778.html: Added.
Add regression test.

* Source/WebCore/Modules/WebGPU/GPUBindGroup.cpp:
(WebCore::GPUBindGroup::updateExternalTextures):
* Source/WebCore/Modules/WebGPU/GPUBindGroup.h:
* Source/WebCore/Modules/WebGPU/GPUDevice.cpp:
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUBindGroupImpl.cpp:
(WebCore::WebGPU::BindGroupImpl::updateExternalTextures):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUBindGroupImpl.h:
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBindGroup.h:
* Source/WebGPU/WebGPU/BindGroup.h:
* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::BindGroup::updateExternalTextures):
(wgpuBindGroupUpdateExternalTextures):
* Source/WebGPU/WebGPU/ExternalTexture.h:
* Source/WebGPU/WebGPU/ExternalTexture.mm:
(WebGPU::ExternalTexture::openCommandEncoderCount const):
* Source/WebGPU/WebGPU/WebGPUExt.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.cpp:
(WebKit::RemoteBindGroup::updateExternalTextures):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.messages.in:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBindGroupProxy.cpp:
(WebKit::WebGPU::RemoteBindGroupProxy::updateExternalTextures):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBindGroupProxy.h:

Canonical link: https://commits.webkit.org/285574@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications