[webkit-changes] [WebKit/WebKit] ac3abe: Cherry-pick 285325 at main (5397a7b48c68). https://bu...

Georges Basile Stavracas Neto noreply at github.com
Mon Oct 21 15:20:49 PDT 2024


  Branch: refs/heads/webkitglib/2.46
  Home:   https://github.com/WebKit/WebKit
  Commit: ac3abe63bdc8c7ced8abfac9d714e6402529c10a
      https://github.com/WebKit/WebKit/commit/ac3abe63bdc8c7ced8abfac9d714e6402529c10a
  Author: Georges Basile Stavracas Neto <feaneron at igalia.com>
  Date:   2024-10-22 (Tue, 22 Oct 2024)

  Changed paths:
    M Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp

  Log Message:
  -----------
  Cherry-pick 285325 at main (5397a7b48c68). https://bugs.webkit.org/show_bug.cgi?id=281492

    AX: [GTK]: Fix crash in AccessibilityObjectAtspi::textAttributes
    https://bugs.webkit.org/show_bug.cgi?id=281492

    Reviewed by Carlos Garcia Campos.

    In the AccessibilityObjectAtspi::textAttributes() method, the
    accessibilityTextAttributes() function is called for various AXObjects.
    These objects are retrived by querying the AXObjectCache of the
    document.

    However, the cache can legitimately return nullptr when the AXObject is
    not cached. The AccessibilityObjectAtspi::textAttributes() method did
    not check for nullptr, and the accessibilityTextAttributes() function
    is not nullptr safe.

    This crashes.

    Make AccessibilityObjectAtspi::textAttributes() check if the AXObject
    is a nullptr before passing it down to accessibilityTextAttributes().

    * Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp:
    (WebCore::AccessibilityObjectAtspi::textAttributes const):

    Canonical link: https://commits.webkit.org/285325@main

Canonical link: https://commits.webkit.org/282416.231@webkitglib/2.46



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list