[webkit-changes] [WebKit/WebKit] 45e2f4: [view-transitions] "Capture old state" should clea...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 45e2f437b91c9aaeb1aa984bb6e4404e9f3fddac
      https://github.com/WebKit/WebKit/commit/45e2f437b91c9aaeb1aa984bb6e4404e9f3fddac
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-10-21 (Mon, 21 Oct 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/capture-old-state-error-flag-cleanup-expected.xht
    A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/capture-old-state-error-flag-cleanup.html
    M Source/WebCore/dom/ViewTransition.cpp

  Log Message:
  -----------
  [view-transitions] "Capture old state" should clean up captured flag on error
https://bugs.webkit.org/show_bug.cgi?id=281867
rdar://138338884

Reviewed by Matt Woodrow.

This was a spec bug, see:

https://github.com/w3c/csswg-drafts/issues/11058
https://github.com/w3c/csswg-drafts/commit/f894d41d3ce3f75b82339aa454af4e1b7ac2a325

We were not cleaning up properly the "captured in view transition" flag properly on error,
which lead to renderers not being painted despite the view transition having been skipped.

* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/capture-old-state-error-flag-cleanup-expected.xht: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/capture-old-state-error-flag-cleanup.html: Added.
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::captureOldState):

Canonical link: https://commits.webkit.org/285535@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications