[webkit-changes] [WebKit/WebKit] df17cf: Add support for loading an extension resources as ...

Timothy Hatcher noreply at github.com
Mon Oct 21 10:12:51 PDT 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: df17cf322962aa8dbddc710428fb2334c13139e9
      https://github.com/WebKit/WebKit/commit/df17cf322962aa8dbddc710428fb2334c13139e9
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-10-21 (Mon, 21 Oct 2024)

  Changed paths:
    M Source/WTF/wtf/FileSystem.cpp
    M Source/WTF/wtf/FileSystem.h
    M Source/WTF/wtf/cocoa/FileSystemCocoa.mm
    M Source/WebCore/en.lproj/Localizable.strings
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionPrivate.h
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
    M Source/WebKit/UIProcess/Extensions/WebExtension.cpp
    M Source/WebKit/UIProcess/Extensions/WebExtension.h
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    A Tools/TestWebKitAPI/Tests/WebKit/web-extension.crx
    A Tools/TestWebKitAPI/Tests/WebKit/web-extension.zip
    A Tools/TestWebKitAPI/Tests/WebKit/web-extension/_locales/en/messages.json
    A Tools/TestWebKitAPI/Tests/WebKit/web-extension/background.js
    A Tools/TestWebKitAPI/Tests/WebKit/web-extension/content.js
    A Tools/TestWebKitAPI/Tests/WebKit/web-extension/images/icon-128.png
    A Tools/TestWebKitAPI/Tests/WebKit/web-extension/images/icon-256.png
    A Tools/TestWebKitAPI/Tests/WebKit/web-extension/images/icon-48.png
    A Tools/TestWebKitAPI/Tests/WebKit/web-extension/images/icon-512.png
    A Tools/TestWebKitAPI/Tests/WebKit/web-extension/images/icon-64.png
    A Tools/TestWebKitAPI/Tests/WebKit/web-extension/images/icon-96.png
    A Tools/TestWebKitAPI/Tests/WebKit/web-extension/images/toolbar-icon.svg
    A Tools/TestWebKitAPI/Tests/WebKit/web-extension/manifest.json
    A Tools/TestWebKitAPI/Tests/WebKit/web-extension/popup.css
    A Tools/TestWebKitAPI/Tests/WebKit/web-extension/popup.html
    A Tools/TestWebKitAPI/Tests/WebKit/web-extension/popup.js
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-ios.appex/Info.plist
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-ios.appex/Test Extension Extension
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-ios.appex/_CodeSignature/CodeResources
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-ios.appex/_locales/en/messages.json
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-ios.appex/background.js
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-ios.appex/content.js
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-ios.appex/images/icon-128.png
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-ios.appex/images/icon-256.png
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-ios.appex/images/icon-48.png
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-ios.appex/images/icon-512.png
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-ios.appex/images/icon-64.png
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-ios.appex/images/icon-96.png
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-ios.appex/images/toolbar-icon.svg
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-ios.appex/manifest.json
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-ios.appex/popup.css
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-ios.appex/popup.html
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-ios.appex/popup.js
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-mac.appex/Contents/Info.plist
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-mac.appex/Contents/MacOS/Test Extension Extension
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-mac.appex/Contents/Resources/_locales/en/messages.json
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-mac.appex/Contents/Resources/background.js
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-mac.appex/Contents/Resources/content.js
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-mac.appex/Contents/Resources/images/icon-128.png
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-mac.appex/Contents/Resources/images/icon-256.png
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-mac.appex/Contents/Resources/images/icon-48.png
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-mac.appex/Contents/Resources/images/icon-512.png
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-mac.appex/Contents/Resources/images/icon-64.png
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-mac.appex/Contents/Resources/images/icon-96.png
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-mac.appex/Contents/Resources/images/toolbar-icon.svg
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-mac.appex/Contents/Resources/manifest.json
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-mac.appex/Contents/Resources/popup.css
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-mac.appex/Contents/Resources/popup.html
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-mac.appex/Contents/Resources/popup.js
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-mac.appex/Contents/_CodeSignature/CodeResources

  Log Message:
  -----------
  Add support for loading an extension resources as a zip file.
https://webkit.org/b/281320
rdar://136784811

Reviewed by Brian Weinstein.

Support loading ZIP and CRX files directly with a WKWebExtension.

* Source/WTF/wtf/FileSystem.cpp:
(WTF::FileSystemImpl::extractTemporaryZipArchive): Added.
* Source/WTF/wtf/FileSystem.h:
* Source/WTF/wtf/cocoa/FileSystemCocoa.mm:
(WTF::FileSystemImpl::createTemporaryZipArchive): Cleaned up.
(WTF::FileSystemImpl::extractTemporaryZipArchive): Added.
* Source/WebCore/en.lproj/Localizable.strings: Updated.
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.h:
(NS_ERROR_ENUM): Added WKWebExtensionErrorInvalidArchive.
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.mm:
(+[WKWebExtension extensionWithResourceBaseURL:completionHandler:]): Remove directory assert.
(-[WKWebExtension _initWithAppExtensionBundle:resourceBaseURL:error:]): Ditto.
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionPrivate.h:
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::convertChromeExtensionToTemporaryZipFile): Added.
(WebKit::processFileAndExtractZipArchive): Added.
(WebKit::WebExtension::WebExtension): Use processFileAndExtractZipArchive when it is a directory.
* Source/WebKit/UIProcess/Extensions/WebExtension.cpp:
(WebKit::toAPI): Added InvalidArchive.
(WebKit::WebExtension::createError): Ditto.
* Source/WebKit/UIProcess/Extensions/WebExtension.h:
* Tools/TestWebKitAPI/Tests/WebKit/web-extension.crx: Added.
* Tools/TestWebKitAPI/Tests/WebKit/web-extension.zip: Added.
* Tools/TestWebKitAPI/Tests/WebKit/web-extension/: Added.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm:
(TestWebKitAPI::TEST(WKWebExtension, LoadFromDirectory)): Added.
(TestWebKitAPI::TEST(WKWebExtension, LoadFromZipArchive)): Added.
(TestWebKitAPI::TEST(WKWebExtension, LoadFromChromeExtensionArchive)): Added.
(TestWebKitAPI::TEST(WKWebExtension, LoadFromMacAppExtensionBundle)): Added.
(TestWebKitAPI::TEST(WKWebExtension, LoadFromiOSAppExtensionBundle)): Added.
(TestWebKitAPI::TEST(WKWebExtension, LoadWithBadURL)): Added.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-ios.appex/: Added.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/web-extension-mac.appex/: Added.

Canonical link: https://commits.webkit.org/285511@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list