[webkit-changes] [WebKit/WebKit] 637b69: REGRESSION: storage.onChanged returns undefined as...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 637b693b65db16fb1cf6e469e73c8bf99774aaa0
      https://github.com/WebKit/WebKit/commit/637b693b65db16fb1cf6e469e73c8bf99774aaa0
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-10-21 (Mon, 21 Oct 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIStorageCocoa.mm
    M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIStorageCocoa.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIStorage.mm

  Log Message:
  -----------
  REGRESSION: storage.onChanged returns undefined as the areaName.
https://webkit.org/b/281644
rdar://problem/138086765

Reviewed by Brian Weinstein.

Add `areaName` to the arguments for `onChanged` and simplify the processing of `changes`.
Also added tests for `changes` and `areaName` that were missing.

* Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIStorageCocoa.mm:
(WebKit::WebExtensionContext::fireStorageChangedEventIfNeeded): Simplified.
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIStorageCocoa.mm:
(WebKit::WebExtensionContextProxy::dispatchStorageChangedEvent): Added `areaName`.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIStorage.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIStorage, StorageOnChanged)): Expanded test.
(TestWebKitAPI::TEST(WKWebExtensionAPIStorage, StorageAreaOnChanged)): Ditto.

Canonical link: https://commits.webkit.org/285510@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications