[webkit-changes] [WebKit/WebKit] f51a90: Clean up UI process back/forward state during prov...

Charlie Wolfe noreply at github.com
Fri Oct 18 10:41:31 PDT 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f51a9069c20e133bcf8b29b45fe56302b783eed8
      https://github.com/WebKit/WebKit/commit/f51a9069c20e133bcf8b29b45fe56302b783eed8
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-10-18 (Fri, 18 Oct 2024)

  Changed paths:
    M LayoutTests/contentfiltering/allow-after-add-data-expected.txt
    M LayoutTests/contentfiltering/allow-after-finished-adding-data-expected.txt
    M LayoutTests/contentfiltering/allow-after-response-expected.txt
    M LayoutTests/contentfiltering/allow-after-will-send-request-expected.txt
    M LayoutTests/contentfiltering/allow-never-expected.txt
    M LayoutTests/contentfiltering/block-after-add-data-expected.txt
    M LayoutTests/contentfiltering/block-after-add-data-then-allow-unblock-expected.txt
    M LayoutTests/contentfiltering/block-after-add-data-then-deny-unblock-expected.txt
    M LayoutTests/contentfiltering/block-after-finished-adding-data-expected.txt
    M LayoutTests/contentfiltering/block-after-finished-adding-data-then-allow-unblock-expected.txt
    M LayoutTests/contentfiltering/block-after-finished-adding-data-then-deny-unblock-expected.txt
    M LayoutTests/contentfiltering/block-after-response-expected.txt
    M LayoutTests/contentfiltering/block-after-response-then-allow-unblock-expected.txt
    M LayoutTests/contentfiltering/block-after-response-then-deny-unblock-expected.txt
    M LayoutTests/contentfiltering/block-after-will-send-request-expected.txt
    M LayoutTests/contentfiltering/block-after-will-send-request-then-allow-unblock-expected.txt
    M LayoutTests/contentfiltering/block-after-will-send-request-then-deny-unblock-expected.txt
    M LayoutTests/contentfiltering/block-never-expected.txt
    M LayoutTests/fast/history/back-from-page-with-focused-iframe-expected.txt
    M LayoutTests/fast/history/form-submit-in-frame-expected.txt
    M LayoutTests/fast/history/form-submit-in-frame-via-onclick-expected.txt
    M LayoutTests/fast/history/gesture-before-onload-form-submit-expected.txt
    M LayoutTests/fast/history/gesture-before-onload-location-href-expected.txt
    M LayoutTests/fast/history/history-back-initial-vs-final-url-expected.txt
    M LayoutTests/fast/history/redirect-via-iframe-expected.txt
    M LayoutTests/fast/history/same-document-iframes-changing-fragment-expected.txt
    M LayoutTests/fast/history/same-document-iframes-changing-pushstate-expected.txt
    M LayoutTests/fast/loader/dynamic-iframe-extra-back-forward-item-expected.txt
    M LayoutTests/fast/loader/form-submission-before-load-get-expected.txt
    M LayoutTests/fast/loader/form-submission-before-load-post-expected.txt
    M LayoutTests/fast/loader/fragment-after-redirect-gets-back-entry-expected.txt
    M LayoutTests/fast/loader/frame-location-change-not-added-to-history-expected.txt
    M LayoutTests/fast/loader/frame-src-change-added-to-history-expected.txt
    M LayoutTests/fast/loader/frame-src-change-not-added-to-history-expected.txt
    M LayoutTests/fast/loader/stateobjects/pushstate-clears-forward-history-expected.txt
    M LayoutTests/fast/loader/subframe-navigate-during-main-frame-load-expected.txt
    M LayoutTests/http/tests/history/back-with-fragment-change-expected.txt
    M LayoutTests/http/tests/history/history-replace-updates-current-item-expected.txt
    M LayoutTests/http/tests/history/redirect-200-refresh-0-seconds-expected.txt
    M LayoutTests/http/tests/history/redirect-200-refresh-2-seconds-expected.txt
    M LayoutTests/http/tests/history/redirect-301-expected.txt
    M LayoutTests/http/tests/history/redirect-302-expected.txt
    M LayoutTests/http/tests/history/redirect-303-expected.txt
    M LayoutTests/http/tests/history/redirect-307-expected.txt
    M LayoutTests/http/tests/history/redirect-js-document-location-0-seconds-expected.txt
    M LayoutTests/http/tests/history/redirect-js-document-location-2-seconds-expected.txt
    M LayoutTests/http/tests/history/redirect-js-document-location-before-load-expected.txt
    M LayoutTests/http/tests/history/redirect-js-form-submit-0-seconds-expected.txt
    M LayoutTests/http/tests/history/redirect-js-form-submit-2-seconds-expected.txt
    M LayoutTests/http/tests/history/redirect-js-form-submit-before-load-expected.txt
    M LayoutTests/http/tests/history/redirect-js-location-0-seconds-expected.txt
    M LayoutTests/http/tests/history/redirect-js-location-2-seconds-expected.txt
    M LayoutTests/http/tests/history/redirect-js-location-assign-0-seconds-expected.txt
    M LayoutTests/http/tests/history/redirect-js-location-assign-2-seconds-expected.txt
    M LayoutTests/http/tests/history/redirect-js-location-assign-before-load-expected.txt
    M LayoutTests/http/tests/history/redirect-js-location-before-load-expected.txt
    M LayoutTests/http/tests/history/redirect-js-location-href-0-seconds-expected.txt
    M LayoutTests/http/tests/history/redirect-js-location-href-2-seconds-expected.txt
    M LayoutTests/http/tests/history/redirect-js-location-href-before-load-expected.txt
    M LayoutTests/http/tests/history/redirect-js-location-replace-0-seconds-expected.txt
    M LayoutTests/http/tests/history/redirect-js-location-replace-2-seconds-expected.txt
    M LayoutTests/http/tests/history/redirect-js-location-replace-before-load-expected.txt
    M LayoutTests/http/tests/history/redirect-meta-refresh-0-seconds-expected.txt
    M LayoutTests/http/tests/history/redirect-meta-refresh-2-seconds-expected.txt
    M LayoutTests/http/tests/navigation/anchor-basic-expected.txt
    M LayoutTests/http/tests/navigation/anchor-goback-expected.txt
    M LayoutTests/http/tests/navigation/anchor-subframeload-expected.txt
    M LayoutTests/http/tests/navigation/back-to-slow-frame-expected.txt
    M LayoutTests/http/tests/navigation/back-twice-without-commit-expected.txt
    M LayoutTests/http/tests/navigation/document-location-click-expected.txt
    M LayoutTests/http/tests/navigation/document-location-click-timeout-expected.txt
    M LayoutTests/http/tests/navigation/document-location-mouseover-expected.txt
    M LayoutTests/http/tests/navigation/document-location-onload-expected.txt
    M LayoutTests/http/tests/navigation/document-location-script-expected.txt
    M LayoutTests/http/tests/navigation/dynamic-iframe-dynamic-form-back-entry-expected.txt
    M LayoutTests/http/tests/navigation/error404-frames-expected.txt
    M LayoutTests/http/tests/navigation/forward-and-cancel-expected.txt
    M LayoutTests/http/tests/navigation/javascriptlink-basic-expected.txt
    M LayoutTests/http/tests/navigation/javascriptlink-goback-expected.txt
    M LayoutTests/http/tests/navigation/javascriptlink-subframeload-expected.txt
    M LayoutTests/http/tests/navigation/location-assign-adds-history-item-expected.txt
    M LayoutTests/http/tests/navigation/location-href-set-adds-history-item-expected.txt
    M LayoutTests/http/tests/navigation/location-replace-adds-history-item-expected.txt
    M LayoutTests/http/tests/navigation/location-set-adds-history-item-expected.txt
    M LayoutTests/http/tests/navigation/lockedhistory-iframe-expected.txt
    M LayoutTests/http/tests/navigation/metaredirect-basic-expected.txt
    M LayoutTests/http/tests/navigation/metaredirect-frames-expected.txt
    M LayoutTests/http/tests/navigation/metaredirect-goback-expected.txt
    M LayoutTests/http/tests/navigation/metaredirect-subframeload-expected.txt
    M LayoutTests/http/tests/navigation/multiple-back-forward-entries-expected.txt
    M LayoutTests/http/tests/navigation/navigation-interrupted-by-fragment-expected.txt
    M LayoutTests/http/tests/navigation/new-window-redirect-history-expected.txt
    M LayoutTests/http/tests/navigation/onload-navigation-iframe-2-expected.txt
    M LayoutTests/http/tests/navigation/onload-navigation-iframe-expected.txt
    M LayoutTests/http/tests/navigation/onload-navigation-iframe-timeout-expected.txt
    M LayoutTests/http/tests/navigation/parsed-iframe-dynamic-form-back-entry-expected.txt
    M LayoutTests/http/tests/navigation/post-basic-expected.txt
    M LayoutTests/http/tests/navigation/post-frames-expected.txt
    M LayoutTests/http/tests/navigation/post-frames-goback1-expected.txt
    M LayoutTests/http/tests/navigation/post-frames-goback1-uncached-expected.txt
    M LayoutTests/http/tests/navigation/post-goback-same-url-expected.txt
    M LayoutTests/http/tests/navigation/post-goback1-expected.txt
    M LayoutTests/http/tests/navigation/post-goback2-expected.txt
    M LayoutTests/http/tests/navigation/postredirect-frames-expected.txt
    M LayoutTests/http/tests/navigation/postredirect-frames-goback1-expected.txt
    M LayoutTests/http/tests/navigation/postredirect-goback2-expected.txt
    M LayoutTests/http/tests/navigation/postredirect-reload-expected.txt
    M LayoutTests/http/tests/navigation/redirect-cycle-expected.txt
    M LayoutTests/http/tests/navigation/redirect-load-no-form-restoration-expected.txt
    M LayoutTests/http/tests/navigation/redirect-on-back-updates-history-item-expected.txt
    M LayoutTests/http/tests/navigation/redirect-on-reload-updates-history-item-expected.txt
    M LayoutTests/http/tests/navigation/redirect302-basic-expected.txt
    M LayoutTests/http/tests/navigation/redirect302-frames-expected.txt
    M LayoutTests/http/tests/navigation/redirect302-goback-expected.txt
    M LayoutTests/http/tests/navigation/redirect302-metaredirect-expected.txt
    M LayoutTests/http/tests/navigation/redirect302-subframeload-expected.txt
    M LayoutTests/http/tests/navigation/relativeanchor-basic-expected.txt
    M LayoutTests/http/tests/navigation/relativeanchor-frames-expected.txt
    M LayoutTests/http/tests/navigation/relativeanchor-goback-expected.txt
    M LayoutTests/http/tests/navigation/response204-expected.txt
    M LayoutTests/http/tests/navigation/restore-form-state-https-expected.txt
    M LayoutTests/http/tests/navigation/sec-fetch-site-header-expected.txt
    M LayoutTests/http/tests/navigation/sec-fetch-site-header-on-crossorigin-redirection-expected.txt
    M LayoutTests/http/tests/navigation/sec-fetch-site-header-on-redirection-expected.txt
    M LayoutTests/http/tests/navigation/slowmetaredirect-basic-expected.txt
    M LayoutTests/http/tests/navigation/slowtimerredirect-basic-expected.txt
    M LayoutTests/http/tests/navigation/statistics-expected.txt
    M LayoutTests/http/tests/navigation/success200-basic-expected.txt
    M LayoutTests/http/tests/navigation/success200-frames-expected.txt
    M LayoutTests/http/tests/navigation/success200-frames-loadsame-expected.txt
    M LayoutTests/http/tests/navigation/success200-goback-expected.txt
    M LayoutTests/http/tests/navigation/success200-loadsame-expected.txt
    M LayoutTests/http/tests/navigation/success200-reload-expected.txt
    M LayoutTests/http/tests/navigation/success200-subframeload-expected.txt
    M LayoutTests/http/tests/navigation/timerredirect-basic-expected.txt
    M LayoutTests/http/tests/navigation/timerredirect-frames-expected.txt
    M LayoutTests/http/tests/navigation/timerredirect-goback-expected.txt
    M LayoutTests/http/tests/navigation/timerredirect-subframeload-expected.txt
    M LayoutTests/http/tests/navigation/window-open-adds-history-item-expected.txt
    M LayoutTests/http/tests/navigation/window-open-adds-history-item2-expected.txt
    M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-allowed-expected.txt
    M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-blocked-expected.txt
    M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-default-ignored-expected.txt
    M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-allowed-expected.txt
    M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked-expected.txt
    M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-javascript-blocked-expected.txt
    M LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-self-blocked-expected.txt
    M LayoutTests/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-uir-on-navigation-expected.txt
    M LayoutTests/platform/glib/http/tests/navigation/error404-basic-expected.txt
    M LayoutTests/platform/glib/http/tests/navigation/error404-goback-expected.txt
    M LayoutTests/platform/glib/http/tests/navigation/postredirect-basic-expected.txt
    M LayoutTests/platform/glib/http/tests/navigation/postredirect-goback1-expected.txt
    M LayoutTests/platform/gtk/http/tests/navigation/error404-subframeload-expected.txt
    M LayoutTests/platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt
    M LayoutTests/platform/ios/http/tests/navigation/error404-basic-expected.txt
    M LayoutTests/platform/ios/http/tests/navigation/error404-goback-expected.txt
    M LayoutTests/platform/ios/http/tests/navigation/error404-subframeload-expected.txt
    M LayoutTests/platform/ios/http/tests/navigation/javascriptlink-frames-expected.txt
    M LayoutTests/platform/ios/http/tests/navigation/postredirect-basic-expected.txt
    M LayoutTests/platform/ios/http/tests/navigation/postredirect-goback1-expected.txt
    M LayoutTests/platform/mac-ventura/http/tests/navigation/javascriptlink-frames-expected.txt
    M LayoutTests/platform/mac-wk1/http/tests/navigation/sec-fetch-site-header-expected.txt
    M LayoutTests/platform/mac-wk1/http/tests/navigation/sec-fetch-site-header-on-crossorigin-redirection-expected.txt
    M LayoutTests/platform/mac-wk1/http/tests/navigation/sec-fetch-site-header-on-redirection-expected.txt
    M LayoutTests/platform/mac/http/tests/navigation/error404-basic-expected.txt
    M LayoutTests/platform/mac/http/tests/navigation/error404-goback-expected.txt
    M LayoutTests/platform/mac/http/tests/navigation/error404-subframeload-expected.txt
    M LayoutTests/platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt
    M LayoutTests/platform/mac/http/tests/navigation/postredirect-basic-expected.txt
    M LayoutTests/platform/mac/http/tests/navigation/postredirect-goback1-expected.txt
    M LayoutTests/platform/wpe/http/tests/navigation/javascriptlink-frames-expected.txt
    M Source/WebCore/history/BackForwardClient.h
    M Source/WebCore/history/BackForwardController.cpp
    M Source/WebCore/history/BackForwardController.h
    M Source/WebCore/history/HistoryItem.cpp
    M Source/WebCore/history/HistoryItem.h
    M Source/WebCore/loader/EmptyClients.cpp
    M Source/WebCore/loader/FrameLoader.cpp
    M Source/WebCore/loader/HistoryController.cpp
    M Source/WebKit/UIProcess/WebBackForwardList.cpp
    M Source/WebKit/UIProcess/WebBackForwardList.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/WebProcess/WebPage/WebBackForwardListProxy.cpp
    M Source/WebKit/WebProcess/WebPage/WebBackForwardListProxy.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKitLegacy/mac/History/BackForwardList.h
    M Source/WebKitLegacy/mac/History/BackForwardList.mm
    M Source/WebKitLegacy/mac/History/WebHistoryItem.mm
    M Source/WebKitLegacy/mac/History/WebHistoryItemPrivate.h
    M Tools/DumpRenderTree/mac/DumpRenderTree.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm

  Log Message:
  -----------
  Clean up UI process back/forward state during provisional navigations
https://bugs.webkit.org/show_bug.cgi?id=281704
rdar://138150829

Reviewed by Alex Christensen.

When a back/forward navigation begins, we update the back/forward list in the UI process before the
navigation commits. This allows a client to quickly navigate back or forward again, even before the
navigation commits. Because of this, we have logic in `FrameLoader::continueLoadAfterNavigationPolicy`
to return the back/forward cursor to the previous item if the provisional navigation was canceled.
Instead of doing this, we should make the list in the UI process aware when a back/forward navigation has
started but not yet committed. The back/forward list will then use the provisional cursor until it is
either cleared or notified to switch to a non-provisional item.

`HistoryItem` now no longer needs to track whether it belongs to a navigated frame, so `m_isTargetItem`
can be removed.

I also added a test to ensure the back/forward cursor still returns to the previous item after canceling
a provisional navigation.

* LayoutTests/contentfiltering/allow-after-add-data-expected.txt:
* LayoutTests/contentfiltering/allow-after-finished-adding-data-expected.txt:
* LayoutTests/contentfiltering/allow-after-response-expected.txt:
* LayoutTests/contentfiltering/allow-after-will-send-request-expected.txt:
* LayoutTests/contentfiltering/allow-never-expected.txt:
* LayoutTests/contentfiltering/block-after-add-data-expected.txt:
* LayoutTests/contentfiltering/block-after-add-data-then-allow-unblock-expected.txt:
* LayoutTests/contentfiltering/block-after-add-data-then-deny-unblock-expected.txt:
* LayoutTests/contentfiltering/block-after-finished-adding-data-expected.txt:
* LayoutTests/contentfiltering/block-after-finished-adding-data-then-allow-unblock-expected.txt:
* LayoutTests/contentfiltering/block-after-finished-adding-data-then-deny-unblock-expected.txt:
* LayoutTests/contentfiltering/block-after-response-expected.txt:
* LayoutTests/contentfiltering/block-after-response-then-allow-unblock-expected.txt:
* LayoutTests/contentfiltering/block-after-response-then-deny-unblock-expected.txt:
* LayoutTests/contentfiltering/block-after-will-send-request-expected.txt:
* LayoutTests/contentfiltering/block-after-will-send-request-then-allow-unblock-expected.txt:
* LayoutTests/contentfiltering/block-after-will-send-request-then-deny-unblock-expected.txt:
* LayoutTests/contentfiltering/block-never-expected.txt:
* LayoutTests/fast/history/back-from-page-with-focused-iframe-expected.txt:
* LayoutTests/fast/history/form-submit-in-frame-expected.txt:
* LayoutTests/fast/history/form-submit-in-frame-via-onclick-expected.txt:
* LayoutTests/fast/history/gesture-before-onload-form-submit-expected.txt:
* LayoutTests/fast/history/gesture-before-onload-location-href-expected.txt:
* LayoutTests/fast/history/history-back-initial-vs-final-url-expected.txt:
* LayoutTests/fast/history/redirect-via-iframe-expected.txt:
* LayoutTests/fast/history/same-document-iframes-changing-fragment-expected.txt:
* LayoutTests/fast/history/same-document-iframes-changing-pushstate-expected.txt:
* LayoutTests/fast/loader/dynamic-iframe-extra-back-forward-item-expected.txt:
* LayoutTests/fast/loader/form-submission-before-load-get-expected.txt:
* LayoutTests/fast/loader/form-submission-before-load-post-expected.txt:
* LayoutTests/fast/loader/fragment-after-redirect-gets-back-entry-expected.txt:
* LayoutTests/fast/loader/frame-location-change-not-added-to-history-expected.txt:
* LayoutTests/fast/loader/frame-src-change-added-to-history-expected.txt:
* LayoutTests/fast/loader/frame-src-change-not-added-to-history-expected.txt:
* LayoutTests/fast/loader/stateobjects/pushstate-clears-forward-history-expected.txt:
* LayoutTests/fast/loader/subframe-navigate-during-main-frame-load-expected.txt:
* LayoutTests/http/tests/history/back-with-fragment-change-expected.txt:
* LayoutTests/http/tests/history/history-replace-updates-current-item-expected.txt:
* LayoutTests/http/tests/history/redirect-200-refresh-0-seconds-expected.txt:
* LayoutTests/http/tests/history/redirect-200-refresh-2-seconds-expected.txt:
* LayoutTests/http/tests/history/redirect-301-expected.txt:
* LayoutTests/http/tests/history/redirect-302-expected.txt:
* LayoutTests/http/tests/history/redirect-303-expected.txt:
* LayoutTests/http/tests/history/redirect-307-expected.txt:
* LayoutTests/http/tests/history/redirect-js-document-location-0-seconds-expected.txt:
* LayoutTests/http/tests/history/redirect-js-document-location-2-seconds-expected.txt:
* LayoutTests/http/tests/history/redirect-js-document-location-before-load-expected.txt:
* LayoutTests/http/tests/history/redirect-js-form-submit-0-seconds-expected.txt:
* LayoutTests/http/tests/history/redirect-js-form-submit-2-seconds-expected.txt:
* LayoutTests/http/tests/history/redirect-js-form-submit-before-load-expected.txt:
* LayoutTests/http/tests/history/redirect-js-location-0-seconds-expected.txt:
* LayoutTests/http/tests/history/redirect-js-location-2-seconds-expected.txt:
* LayoutTests/http/tests/history/redirect-js-location-assign-0-seconds-expected.txt:
* LayoutTests/http/tests/history/redirect-js-location-assign-2-seconds-expected.txt:
* LayoutTests/http/tests/history/redirect-js-location-assign-before-load-expected.txt:
* LayoutTests/http/tests/history/redirect-js-location-before-load-expected.txt:
* LayoutTests/http/tests/history/redirect-js-location-href-0-seconds-expected.txt:
* LayoutTests/http/tests/history/redirect-js-location-href-2-seconds-expected.txt:
* LayoutTests/http/tests/history/redirect-js-location-href-before-load-expected.txt:
* LayoutTests/http/tests/history/redirect-js-location-replace-0-seconds-expected.txt:
* LayoutTests/http/tests/history/redirect-js-location-replace-2-seconds-expected.txt:
* LayoutTests/http/tests/history/redirect-js-location-replace-before-load-expected.txt:
* LayoutTests/http/tests/history/redirect-meta-refresh-0-seconds-expected.txt:
* LayoutTests/http/tests/history/redirect-meta-refresh-2-seconds-expected.txt:
* LayoutTests/http/tests/navigation/anchor-basic-expected.txt:
* LayoutTests/http/tests/navigation/anchor-goback-expected.txt:
* LayoutTests/http/tests/navigation/anchor-subframeload-expected.txt:
* LayoutTests/http/tests/navigation/back-to-slow-frame-expected.txt:
* LayoutTests/http/tests/navigation/back-twice-without-commit-expected.txt:
* LayoutTests/http/tests/navigation/document-location-click-expected.txt:
* LayoutTests/http/tests/navigation/document-location-click-timeout-expected.txt:
* LayoutTests/http/tests/navigation/document-location-mouseover-expected.txt:
* LayoutTests/http/tests/navigation/document-location-onload-expected.txt:
* LayoutTests/http/tests/navigation/document-location-script-expected.txt:
* LayoutTests/http/tests/navigation/dynamic-iframe-dynamic-form-back-entry-expected.txt:
* LayoutTests/http/tests/navigation/error404-frames-expected.txt:
* LayoutTests/http/tests/navigation/forward-and-cancel-expected.txt:
* LayoutTests/http/tests/navigation/javascriptlink-basic-expected.txt:
* LayoutTests/http/tests/navigation/javascriptlink-goback-expected.txt:
* LayoutTests/http/tests/navigation/javascriptlink-subframeload-expected.txt:
* LayoutTests/http/tests/navigation/location-assign-adds-history-item-expected.txt:
* LayoutTests/http/tests/navigation/location-href-set-adds-history-item-expected.txt:
* LayoutTests/http/tests/navigation/location-replace-adds-history-item-expected.txt:
* LayoutTests/http/tests/navigation/location-set-adds-history-item-expected.txt:
* LayoutTests/http/tests/navigation/lockedhistory-iframe-expected.txt:
* LayoutTests/http/tests/navigation/metaredirect-basic-expected.txt:
* LayoutTests/http/tests/navigation/metaredirect-frames-expected.txt:
* LayoutTests/http/tests/navigation/metaredirect-goback-expected.txt:
* LayoutTests/http/tests/navigation/metaredirect-subframeload-expected.txt:
* LayoutTests/http/tests/navigation/multiple-back-forward-entries-expected.txt:
* LayoutTests/http/tests/navigation/navigation-interrupted-by-fragment-expected.txt:
* LayoutTests/http/tests/navigation/new-window-redirect-history-expected.txt:
* LayoutTests/http/tests/navigation/onload-navigation-iframe-2-expected.txt:
* LayoutTests/http/tests/navigation/onload-navigation-iframe-expected.txt:
* LayoutTests/http/tests/navigation/onload-navigation-iframe-timeout-expected.txt:
* LayoutTests/http/tests/navigation/parsed-iframe-dynamic-form-back-entry-expected.txt:
* LayoutTests/http/tests/navigation/post-basic-expected.txt:
* LayoutTests/http/tests/navigation/post-frames-expected.txt:
* LayoutTests/http/tests/navigation/post-frames-goback1-expected.txt:
* LayoutTests/http/tests/navigation/post-frames-goback1-uncached-expected.txt:
* LayoutTests/http/tests/navigation/post-goback-same-url-expected.txt:
* LayoutTests/http/tests/navigation/post-goback1-expected.txt:
* LayoutTests/http/tests/navigation/post-goback2-expected.txt:
* LayoutTests/http/tests/navigation/postredirect-frames-expected.txt:
* LayoutTests/http/tests/navigation/postredirect-frames-goback1-expected.txt:
* LayoutTests/http/tests/navigation/postredirect-goback2-expected.txt:
* LayoutTests/http/tests/navigation/postredirect-reload-expected.txt:
* LayoutTests/http/tests/navigation/redirect-cycle-expected.txt:
* LayoutTests/http/tests/navigation/redirect-load-no-form-restoration-expected.txt:
* LayoutTests/http/tests/navigation/redirect-on-back-updates-history-item-expected.txt:
* LayoutTests/http/tests/navigation/redirect-on-reload-updates-history-item-expected.txt:
* LayoutTests/http/tests/navigation/redirect302-basic-expected.txt:
* LayoutTests/http/tests/navigation/redirect302-frames-expected.txt:
* LayoutTests/http/tests/navigation/redirect302-goback-expected.txt:
* LayoutTests/http/tests/navigation/redirect302-metaredirect-expected.txt:
* LayoutTests/http/tests/navigation/redirect302-subframeload-expected.txt:
* LayoutTests/http/tests/navigation/relativeanchor-basic-expected.txt:
* LayoutTests/http/tests/navigation/relativeanchor-frames-expected.txt:
* LayoutTests/http/tests/navigation/relativeanchor-goback-expected.txt:
* LayoutTests/http/tests/navigation/response204-expected.txt:
* LayoutTests/http/tests/navigation/restore-form-state-https-expected.txt:
* LayoutTests/http/tests/navigation/sec-fetch-site-header-expected.txt:
* LayoutTests/http/tests/navigation/sec-fetch-site-header-on-crossorigin-redirection-expected.txt:
* LayoutTests/http/tests/navigation/sec-fetch-site-header-on-redirection-expected.txt:
* LayoutTests/http/tests/navigation/slowmetaredirect-basic-expected.txt:
* LayoutTests/http/tests/navigation/slowtimerredirect-basic-expected.txt:
* LayoutTests/http/tests/navigation/statistics-expected.txt:
* LayoutTests/http/tests/navigation/success200-basic-expected.txt:
* LayoutTests/http/tests/navigation/success200-frames-expected.txt:
* LayoutTests/http/tests/navigation/success200-frames-loadsame-expected.txt:
* LayoutTests/http/tests/navigation/success200-goback-expected.txt:
* LayoutTests/http/tests/navigation/success200-loadsame-expected.txt:
* LayoutTests/http/tests/navigation/success200-reload-expected.txt:
* LayoutTests/http/tests/navigation/success200-subframeload-expected.txt:
* LayoutTests/http/tests/navigation/timerredirect-basic-expected.txt:
* LayoutTests/http/tests/navigation/timerredirect-frames-expected.txt:
* LayoutTests/http/tests/navigation/timerredirect-goback-expected.txt:
* LayoutTests/http/tests/navigation/timerredirect-subframeload-expected.txt:
* LayoutTests/http/tests/navigation/window-open-adds-history-item-expected.txt:
* LayoutTests/http/tests/navigation/window-open-adds-history-item2-expected.txt:
* LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-allowed-expected.txt:
* LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-blocked-expected.txt:
* LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-default-ignored-expected.txt:
* LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-allowed-expected.txt:
* LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked-expected.txt:
* LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-javascript-blocked-expected.txt:
* LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-self-blocked-expected.txt:
* LayoutTests/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-uir-on-navigation-expected.txt:
* LayoutTests/platform/glib/http/tests/navigation/error404-basic-expected.txt:
* LayoutTests/platform/glib/http/tests/navigation/error404-goback-expected.txt:
* LayoutTests/platform/glib/http/tests/navigation/postredirect-basic-expected.txt:
* LayoutTests/platform/glib/http/tests/navigation/postredirect-goback1-expected.txt:
* LayoutTests/platform/gtk/http/tests/navigation/error404-subframeload-expected.txt:
* LayoutTests/platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
* LayoutTests/platform/ios/http/tests/navigation/error404-basic-expected.txt:
* LayoutTests/platform/ios/http/tests/navigation/error404-goback-expected.txt:
* LayoutTests/platform/ios/http/tests/navigation/error404-subframeload-expected.txt:
* LayoutTests/platform/ios/http/tests/navigation/javascriptlink-frames-expected.txt:
* LayoutTests/platform/ios/http/tests/navigation/postredirect-basic-expected.txt:
* LayoutTests/platform/ios/http/tests/navigation/postredirect-goback1-expected.txt:
* LayoutTests/platform/mac-ventura/http/tests/navigation/javascriptlink-frames-expected.txt:
* LayoutTests/platform/mac-wk1/http/tests/navigation/sec-fetch-site-header-expected.txt:
* LayoutTests/platform/mac-wk1/http/tests/navigation/sec-fetch-site-header-on-crossorigin-redirection-expected.txt:
* LayoutTests/platform/mac-wk1/http/tests/navigation/sec-fetch-site-header-on-redirection-expected.txt:
* LayoutTests/platform/mac/http/tests/navigation/error404-basic-expected.txt:
* LayoutTests/platform/mac/http/tests/navigation/error404-goback-expected.txt:
* LayoutTests/platform/mac/http/tests/navigation/error404-subframeload-expected.txt:
* LayoutTests/platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
* LayoutTests/platform/mac/http/tests/navigation/postredirect-basic-expected.txt:
* LayoutTests/platform/mac/http/tests/navigation/postredirect-goback1-expected.txt:
* LayoutTests/platform/wpe/http/tests/navigation/javascriptlink-frames-expected.txt:
* Source/WebCore/history/BackForwardClient.h:
* Source/WebCore/history/BackForwardController.cpp:
(WebCore::BackForwardController::setProvisionalItem):
(WebCore::BackForwardController::clearProvisionalItem):
* Source/WebCore/history/BackForwardController.h:
* Source/WebCore/history/HistoryItem.cpp:
(WebCore::HistoryItem::reset):
(WebCore::HistoryItem::setChildItem):
(WebCore::HistoryItem::isTargetItem const): Deleted.
(WebCore::HistoryItem::setIsTargetItem): Deleted.
* Source/WebCore/history/HistoryItem.h:
(WebCore::HistoryItem::frameID const):
* Source/WebCore/loader/EmptyClients.cpp:
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
* Source/WebCore/loader/HistoryController.cpp:
(WebCore::HistoryController::goToItem):
(WebCore::HistoryController::createItemTree):
(WebCore::HistoryController::updateCurrentItem):
* Source/WebKit/UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::~WebBackForwardList):
(WebKit::WebBackForwardList::pageClosed):
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
(WebKit::WebBackForwardList::goToProvisionalItem):
(WebKit::WebBackForwardList::goToItemInternal):
(WebKit::WebBackForwardList::clearProvisionalItem):
(WebKit::WebBackForwardList::currentItem const):
(WebKit::WebBackForwardList::backItem const):
(WebKit::WebBackForwardList::forwardItem const):
(WebKit::WebBackForwardList::itemAtIndex const):
(WebKit::WebBackForwardList::backListCount const):
(WebKit::WebBackForwardList::forwardListCount const):
(WebKit::WebBackForwardList::backListAsAPIArrayWithLimit const):
(WebKit::WebBackForwardList::forwardListAsAPIArrayWithLimit const):
(WebKit::WebBackForwardList::removeAllItems):
(WebKit::WebBackForwardList::clear):
(WebKit::WebBackForwardList::backForwardListState const):
(WebKit::WebBackForwardList::loggingString):
* Source/WebKit/UIProcess/WebBackForwardList.h:
(WebKit::WebBackForwardList::provisionalOrCurrentIndex):
(WebKit::WebBackForwardList::provisionalOrCurrentIndex const):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::backForwardGoToProvisionalItem):
(WebKit::WebPageProxy::backForwardClearProvisionalItem):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::goToProvisionalItem):
(WebKit::WebBackForwardListProxy::clearProvisionalItem):
* Source/WebKit/WebProcess/WebPage/WebBackForwardListProxy.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::dumpHistoryItem):
* Source/WebKitLegacy/mac/History/BackForwardList.h:
* Source/WebKitLegacy/mac/History/BackForwardList.mm:
(BackForwardList::BackForwardList):
(BackForwardList::goToProvisionalItem):
(BackForwardList::clearProvisionalItem):
* Source/WebKitLegacy/mac/History/WebHistoryItem.mm:
(-[WebHistoryItem description]):
* Source/WebKitLegacy/mac/History/WebHistoryItemPrivate.h:
* Tools/DumpRenderTree/mac/DumpRenderTree.mm:
(dumpHistoryItem):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
(TEST(WebKit, DecidePolicyForNavigationActionGoBackAfterCancel)):

Canonical link: https://commits.webkit.org/285421@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list