[webkit-changes] [WebKit/WebKit] 4151f2: Fix TestWebKitAPI.ProcessSwap.ConcurrentHistoryNav...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4151f21189b66da4d379ac320a2342b67d808287
      https://github.com/WebKit/WebKit/commit/4151f21189b66da4d379ac320a2342b67d808287
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-10-18 (Fri, 18 Oct 2024)

  Changed paths:
    M LayoutTests/http/tests/inspector/target/provisional-load-cancels-previous-load-expected.txt
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  Fix TestWebKitAPI.ProcessSwap.ConcurrentHistoryNavigations after 285375 at main
https://bugs.webkit.org/show_bug.cgi?id=281750

Reviewed by Chris Dumez.

The lifetime of ProvisionalPageProxy is quite sensitive.  In particular, in
WebPageProxy::continueNavigationInNewProcess we set m_provisionalPage to null
before creating a new ProvisionalPageProxy, and the destructor of the old one
needs to be called before creating the new one or we will assert in
WebProcessProxy::addVisitedLinkStoreUser.  285375 at main extended the lifetime
of the ProvisionalPageProxy problematically in a few places.  This restores
the old lifetime of the ProvisionalPageProxy without hurting WeakPtr safety.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedNavigationActionPolicyDecision):
(WebKit::WebPageProxy::commitProvisionalPage):

Canonical link: https://commits.webkit.org/285420@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications